Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123504 --- Ship it! Ship It! - Joshua Cohen On March 14, 2016, 7:43

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123496 --- Ship it! Ship It! - John Sirois On March 14, 2016, 1:43

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/ --- (Updated March 14, 2016, 12:43 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 14, 2016, 9:51 a.m., Joshua Cohen wrote: > > Actually, one more thing... should we ensure that the task config it has > > either executor config set or uses a Docker container? I think right now > > you could configure the scheduler with `-require_docker_use_executor=False` > > and

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 14, 2016, 3:51 p.m., Joshua Cohen wrote: > > Actually, one more thing... should we ensure that the task config it has > > either executor config set or uses a Docker container? I think right now > > you could configure the scheduler with `-require_docker_use_executor=False` > > and

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123414 --- Ship it! lgtm modulo the below.

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123241 --- Ship it! Master (de128a1) is green with this patch.

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 11, 2016, 4:07 p.m., John Sirois wrote: > > This LGTM saving for updates to both `docs/configuration-reference.md` and > > `docs/deploying-aurora-scheduler.md`. If consensus is gained that this > > should land, it seems to me the new alternate mode of executing docker > >

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/ --- (Updated March 11, 2016, 3:27 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 11, 2016, 3:07 p.m., John Sirois wrote: > > This LGTM saving for updates to both `docs/configuration-reference.md` and > > `docs/deploying-aurora-scheduler.md`. If consensus is gained that this > > should land, it seems to me the new alternate mode of executing docker > >

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123224 --- Ship it! This LGTM saving for updates to both

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123208 --- Ship it! Master (d752d46) is green with this patch.

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/ --- (Updated March 11, 2016, 11:50 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123156 --- src/main/java/org/apache/aurora/scheduler/app/AppModule.java

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 11, 2016, 1:36 a.m., Joshua Cohen wrote: > > Given the proposal to move towards the Mesos unified containerizer, do you > > think it makes sense to hold off on this and instead implement it in > > conjunction with those upcoming changes? > > > > I haven't gotten any direct feedback

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 5:36 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > line 290 > > > > > > This test doesn't seem appropriately named? It's not

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 5:14 p.m., Aurora ReviewBot wrote: > > Master (72bf8db) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :processJmhResources UP-TO-DATE > > :jmhClasses > > :checkstyleJmh > > :jsHint > > :checkstyleMain > >

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 5:36 p.m., Joshua Cohen wrote: > > Given the proposal to move towards the Mesos unified containerizer, do you > > think it makes sense to hold off on this and instead implement it in > > conjunction with those upcoming changes? > > > > I haven't gotten any direct feedback

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123052 --- nit: I feel like this diff may be better described as "Add

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 4:40 p.m., Zameer Manji wrote: > > I think Josh should be added to this review since he is working on > > supporting the Mesos Universal Containerizer (see his recent design doc to > > dev@) Josh is welcome to chime in :-) Do you mean that i should remove you in favor of

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123045 --- I think Josh should be added to this review since he is working

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123044 ---