Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140155 --- Ship it! Ship It! - Stephan Erb On June 30, 2016, 2:10 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 30, 2016, 2:10 a.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140090 --- Ship it! Master (6f93ae2) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 30, 2016, 12:10 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 30, 2016, 12:10 a.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
> On June 29, 2016, 6:23 p.m., John Sirois wrote: > > @ReviewBot retry > > John Sirois wrote: > FWIW: The failures that lead to this sort of "coverage missing" are all > intergation test connect errors to an in-process servlet engine: > https://gist.github.com/jsirois/32f629a2e950d28e8910fe3d62e928d8 > > I'll see if this is not something obviously fixable. Nothing obviously wrong, ephemeral ports appear to be used in these tests exclusively. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140080 --- On June 29, 2016, 6:10 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 29, 2016, 6:10 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140086 --- Master (6f93ae2) is red with this patch. ./build-support/jenkins/build.sh thrift-0.9.1/tutorial/py/Makefile.am thrift-0.9.1/tutorial/py/Makefile.in thrift-0.9.1/tutorial/py/PythonClient.py thrift-0.9.1/tutorial/py/PythonServer.py thrift-0.9.1/tutorial/py.tornado/ thrift-0.9.1/tutorial/py.tornado/Makefile.am thrift-0.9.1/tutorial/py.tornado/Makefile.in thrift-0.9.1/tutorial/py.tornado/PythonClient.py thrift-0.9.1/tutorial/py.tornado/PythonServer.py thrift-0.9.1/tutorial/py.twisted/ thrift-0.9.1/tutorial/py.twisted/Makefile.am thrift-0.9.1/tutorial/py.twisted/Makefile.in thrift-0.9.1/tutorial/py.twisted/PythonClient.py thrift-0.9.1/tutorial/py.twisted/PythonServer.py thrift-0.9.1/tutorial/py.twisted/PythonServer.tac thrift-0.9.1/tutorial/rb/ thrift-0.9.1/tutorial/rb/Makefile.am thrift-0.9.1/tutorial/rb/Makefile.in thrift-0.9.1/tutorial/rb/RubyClient.rb thrift-0.9.1/tutorial/rb/RubyServer.rb thrift-0.9.1/tutorial/README thrift-0.9.1/tutorial/shared.thrift thrift-0.9.1/tutorial/tutorial.thrift thrift-0.9.1/ylwrap make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift' make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1 :api:generateThriftJava FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':api:generateThriftJava'. > Process 'command > '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' > finished with non-zero exit value 2 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 16.027 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 30, 2016, 12:10 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 30, 2016, 12:10 a.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140085 --- @ReviewBot retry - John Sirois On June 29, 2016, 6:10 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 29, 2016, 6:10 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
> On June 29, 2016, 6:23 p.m., John Sirois wrote: > > @ReviewBot retry FWIW: The failures that lead to this sort of "coverage missing" are all intergation test connect errors to an in-process servlet engine: https://gist.github.com/jsirois/32f629a2e950d28e8910fe3d62e928d8 I'll see if this is not something obviously fixable. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140080 --- On June 29, 2016, 6:10 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 29, 2016, 6:10 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140080 --- @ReviewBot retry - John Sirois On June 29, 2016, 6:10 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 29, 2016, 6:10 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140078 --- Master (6f93ae2) is red with this patch. ./build-support/jenkins/build.sh 1014 tests completed, 31 failed, 2 skipped :test FAILED :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage is 0.8706842152708916, but must be greater than 0.89 Branch coverage is 0.7772420443587271, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build completed with 2 failures. 1: Task failed with an exception. --- * What went wrong: Execution failed for task ':test'. > There were failing tests. See the report at: > file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. == 2: Task failed with an exception. --- * What went wrong: Execution failed for task ':analyzeReport'. > Test coverage missing for > org/apache/aurora/scheduler/http/LeaderRedirectFilter Test coverage missing for org/apache/aurora/scheduler/http/HttpStatsFilter Test coverage missing for org/apache/aurora/scheduler/http/HttpStatsFilter$1 Test coverage missing for org/apache/aurora/scheduler/http/HttpStatsFilter$ResponseWithStatus Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter Test coverage missing for org/apache/aurora/scheduler/http/api/ApiBeta * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. == BUILD FAILED Total time: 6 mins 30.748 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 30, 2016, 12:10 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 30, 2016, 12:10 a.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Re: Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/#review140077 --- NB: The packaging change was here: https://git-wip-us.apache.org/repos/asf?p=aurora-packaging.git;a=commit;h=a665227c0d1634fe69bb9c45559f7d1ff69a4c03 - John Sirois On June 29, 2016, 6:10 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49413/ > --- > > (Updated June 29, 2016, 6:10 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > docs/operations/installation.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Diffs > - > > docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 > > Diff: https://reviews.apache.org/r/49413/diff/ > > > Testing > --- > > Came across the issue testing the 0.13.0 and 0.14.0 releases. > > Rendered here: > > https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 > > > Thanks, > > John Sirois > >
Review Request 49413: Fixup install docs to match 0.13.0+ packaging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49413/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description --- docs/operations/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Diffs - docs/operations/installation.md d3fb529929aaf8975579930d50a59e155d1e4357 Diff: https://reviews.apache.org/r/49413/diff/ Testing --- Came across the issue testing the 0.13.0 and 0.14.0 releases. Rendered here: https://github.com/jsirois/aurora/blob/jsirois/docs/installation/fix/docs/operations/installation.md#centos-7-2 Thanks, John Sirois
