Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review149279 --- Ship it! Master (f1e09a9) is green with this patch. ./build-s

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/ --- (Updated Sept. 16, 2016, 9:04 p.m.) Review request for Aurora, Joshua Cohen, St

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review149275 --- Ship it! Ship It! - Joshua Cohen On Sept. 14, 2016, 11:12 p.

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

> On Sept. 15, 2016, 12:25 p.m., Zameer Manji wrote: > > config/findbugs/excludeFilter.xml, line 123 > > > > > > If I'm reading the code correctly we need this because we have a > > `CompletableFuture` and to give i

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

> On Sept. 15, 2016, 6:25 p.m., Zameer Manji wrote: > > config/findbugs/excludeFilter.xml, line 123 > > > > > > If I'm reading the code correctly we need this because we have a > > `CompletableFuture` and to give it

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

> On Sept. 15, 2016, 12:25 p.m., Zameer Manji wrote: > > config/findbugs/excludeFilter.xml, line 123 > > > > > > If I'm reading the code correctly we need this because we have a > > `CompletableFuture` and to give i

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

> On Sept. 15, 2016, 6:25 p.m., Zameer Manji wrote: > > config/findbugs/excludeFilter.xml, line 123 > > > > > > If I'm reading the code correctly we need this because we have a > > `CompletableFuture` and to give it

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review149182 --- Ship it! Ship It! - Stephan Erb On Sept. 15, 2016, 1:12 a.m.

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review149093 --- Fix it, then Ship it! LGTM, the changes are fairly straight for

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review148996 --- Ship it! Master (5069f93) is green with this patch. ./build-s

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/ --- (Updated Sept. 14, 2016, 11:12 p.m.) Review request for Aurora, Joshua Cohen, S

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

> On Sept. 14, 2016, 5:40 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java, > > lines 164-172 > > > > > > I probably don't completely understand the logic, so stu

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review148933 --- src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJ

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review148836 --- Ship it! Master (5069f93) is green with this patch. ./build-s

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/ --- (Updated Sept. 14, 2016, 12:23 a.m.) Review request for Aurora, Joshua Cohen, S

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review148809 --- Master (633948a) is red with this patch. ./build-support/jenkins

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/ --- (Updated Sept. 13, 2016, 11:14 p.m.) Review request for Aurora, Joshua Cohen, S

Re: Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/#review148356 --- Ship it! Master (c7f710a) is green with this patch. ./build-s

Review Request 51763: Batching writes - Part 2 (of 3): Converting cron jobs to use BatchWorker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51763/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Reposit