Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread John Sirois
> On Sept. 30, 2016, 12:58 p.m., Stephan Erb wrote: > > Do the vagrant files have to be adapted as well? Nope - those support testing and the testing does not use pants, just its products in `.rpm` or `.deb` form. - John --- This is

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151061 --- Ship it! Do the vagrant files have to be adapted as well? -

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151055 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 6:17

Re: Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151053 --- Ship it! Ship It! - Zameer Manji On Sept. 30, 2016, 11:17

Review Request 52428: Add missing libffi build dep to support pants.

2016-09-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: