Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review164643 --- Ship it! Ship It! - Stephan Erb On Feb. 8, 2017, 1:48 a.m.,

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Feb. 7, 2017, 4:48 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Stephan Erb
> On Feb. 6, 2017, 10:01 p.m., Stephan Erb wrote: > > specs/debian/aurora-executor.thermos.service, lines 22-23 > > > > > > Can the corresponding init scripts be dropped? > > Renan DelValle wrote: > We can

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Renan DelValle
> On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote: > > Thanks for the review! > On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote: > > builder/deb/debian-jessie/build.sh, line 28 > > > > > > That indentation seems

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review164402 --- builder/deb/debian-jessie/build.sh (line 28)

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-01 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Feb. 1, 2017, 12:44 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-01-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review160527 --- Ship it! LGTM specs/ubuntu-xenial/changelog (line 1)

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-01-04 Thread Renan DelValle
> On Jan. 4, 2017, 6:01 a.m., Stephan Erb wrote: > > We used to have shared specs for all Debian-based distributions. This patch > > is now duplicating `specs/debian` for `ubuntu-xenial`. Is there anything > > particular that makes this necessary? The reason why I have it a separate the specs

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-01-04 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Jan. 4, 2017, 2:43 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-11-23 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Nov. 23, 2016, 3:03 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-11-03 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review154818 --- Ship it! Ship It! - Dmitriy Shirchenko On Oct. 12, 2016,

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-19 Thread Renan DelValle
> On Oct. 16, 2016, 2:35 p.m., Renan DelValle wrote: > > Attempted to deploy binaries generated by this on my cluster. Everything > > seemed to install fine, but I had issues deploying docker containers. > > Thermos crashes with the following error: > > ``` > > ImportError:

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-19 Thread Zameer Manji
> On Oct. 16, 2016, 2:35 p.m., Renan DelValle wrote: > > Attempted to deploy binaries generated by this on my cluster. Everything > > seemed to install fine, but I had issues deploying docker containers. > > Thermos crashes with the following error: > > ``` > > ImportError:

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-19 Thread Renan DelValle
> On Oct. 16, 2016, 2:35 p.m., Renan DelValle wrote: > > Attempted to deploy binaries generated by this on my cluster. Everything > > seemed to install fine, but I had issues deploying docker containers. > > Thermos crashes with the following error: > > ``` > > ImportError:

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-12 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Oct. 12, 2016, 4:17 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-03 Thread Zameer Manji
> On Oct. 3, 2016, 8:46 a.m., Stephan Erb wrote: > > Packages created for Xenial will still embed the executor eggs for Trusty. > > This is the same problem described here > > https://issues.apache.org/jira/browse/AURORA-1712 > > > > We have to find a way how we can inject the appropriate

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151172 --- Packages created for Xenial will still embed the executor eggs

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Renan DelValle
> On Sept. 30, 2016, 2:31 p.m., Dmitriy Shirchenko wrote: > > builder/deb/ubuntu-xenial/Dockerfile, lines 36-40 > > > > > > For my own curiousity: is the step of adding gpg keys strictly > > necessary? Why does

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151091 --- Ship it! Ship It! - Dmitriy Shirchenko On Sept. 30, 2016,

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151066 --- builder/deb/ubuntu-xenial/Dockerfile (lines 36 - 40)

Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- Review request for Aurora. Repository: aurora-packaging Description ---