Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-03 Thread Zameer Manji
> On Nov. 2, 2016, 8:48 p.m., Joshua Cohen wrote: > > src/main/python/apache/thermos/common/process_util.py, line 72 > > > > > > Prefix this log statement so we have context. It wasn't useful so I removed it in

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/#review154671 --- Overall this looks good to me. I have no idea how to test this

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Stephan Erb
> On Nov. 2, 2016, 10:23 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/runner.py, lines 876-881 > > > > > > The `TaskRunnerHelper.terminate_process` might generate new orphans. > > The call to

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/#review154650 --- Master (13d4861) is red with this patch.

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/ --- (Updated Nov. 2, 2016, 3:13 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/#review154630 --- Master (13d4861) is red with this patch.

Re: Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/ --- (Updated Nov. 2, 2016, 1:32 p.m.) Review request for Aurora, Joshua Cohen,

Review Request 53403: [WIP] [DO NOT MERGE] Reparent orphaned processes to thermos runner and send SIGTERM on task teardown

2016-11-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53403/ --- Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan