Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-06-02 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176852 --- This has been merged to master. - David McLaughlin On June 1,

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176569 --- Ship it! Master (e76862a) is green with this patch.

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/ --- (Updated June 1, 2017, 12:02 a.m.) Review request for Aurora, David

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176555 --- This patch does not apply cleanly against master (e76862a), do

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/ --- (Updated May 31, 2017, 11:44 p.m.) Review request for Aurora, David

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176552 --- I support this idea. However, I need to resign from reviewing

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176538 --- Ship it! Shipt it! Please add a short entry to the

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Stephan Erb
> On May 31, 2017, 12:13 a.m., Stephan Erb wrote: > > Thanks for the patch! That is an interesting idea. I am wondering if it is > > safe in all cases. For example, if I reduce the resource requirements while > > increasing the number of instances, my service could potentially breach his > >

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176481 --- Ship it! +1 to adding the test cases that Josh suggested. -

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176452 --- Ship it! Ship It! - David McLaughlin On May 30, 2017, 9:21

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-30 Thread Jordan Ly
> On May 30, 2017, 10:13 p.m., Stephan Erb wrote: > > Thanks for the patch! That is an interesting idea. I am wondering if it is > > safe in all cases. For example, if I reduce the resource requirements while > > increasing the number of instances, my service could potentially breach his > >

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176371 --- Thanks for the patch! That is an interesting idea. I am wondering

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/#review176367 --- Ship it! Master (d7425aa) is green with this patch.

Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-30 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59640/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan