Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183681 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-23 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/ --- (Updated Aug. 23, 2017, 10:38 p.m.) Review request for Aurora, David

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183584 --- Ship it! This patch looks good to me, thanks!You mentioned

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183541 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183538 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Aug. 22,

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/ --- (Updated Aug. 22, 2017, 9:54 p.m.) Review request for Aurora, David

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Santhosh Kumar Shanmugham
> On Aug. 21, 2017, 9:33 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > > Line 237 (original), 247-248 (patched) > > > > > > Maybe add a metric

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183526 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/ --- (Updated Aug. 22, 2017, 8:33 p.m.) Review request for Aurora, David

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183514 --- Ship it! Ship It! - David McLaughlin On Aug. 22, 2017, 5:05

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Jordan Ly
> On Aug. 22, 2017, 4:33 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > > Line 237 (original), 247-248 (patched) > > > > > > Maybe add a metric

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Santhosh Kumar Shanmugham
> On Aug. 21, 2017, 9:33 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > > Line 237 (original), 247-248 (patched) > > > > > > Maybe add a metric

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183490 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread David McLaughlin
> On Aug. 22, 2017, 4:33 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > > Line 237 (original), 247-248 (patched) > > > > > > Maybe add a metric

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-22 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/ --- (Updated Aug. 22, 2017, 5:05 p.m.) Review request for Aurora, David

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183436 --- I don't have the bandwidth to review this, but this fix seems to

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183421 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/#review183414 --- Master (aae2b0d) is red with this patch.

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-21 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/ --- (Updated Aug. 22, 2017, 12:38 a.m.) Review request for Aurora, David

Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-21 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61804/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan