Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188794 --- Ship it! Master (5397013) is green with this patch.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/ --- (Updated Oct. 19, 2017, 3:48 p.m.) Review request for Aurora and Jordan Ly.

Re: Review Request 63157: Provide a formal way to disable offer declining

> On Oct. 19, 2017, 3:25 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Line 329 (original), 319-324 (patched) > > > > > > Feels like a lot of stuff going on here.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188784 --- Ship it! Master (5397013) is green with this patch.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188776 ---

Re: Review Request 63157: Provide a formal way to disable offer declining

> On Oct. 19, 2017, 1:50 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 188-190 (original), 186-188 (patched) > > > > > > Actually one issue: we no longer

Re: Review Request 63157: Provide a formal way to disable offer declining

> On Oct. 19, 2017, 1:32 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferDecline.java > > Lines 28 (patched) > > > > > > nit: `OfferDecline` seems a bit ambiguious to me at first

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188754 ---

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188753 --- Ship it! Master (a9827fe) is green with this patch.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188752 --- Ship it! Overall LGTM; small nit on naming but it is

Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description