Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192638 --- Ship it! Ship It! - Jordan Ly On Dec. 1, 2017, 12:32 a.m.,

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192636 --- Ship it! Ship It! - Stephan Erb On Dez. 1, 2017, 1:32

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192635 --- Ship it! Master (de8b375) is green with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192634 --- @ReviewBot retry - Bill Farner On Nov. 30, 2017, 4:32 p.m.,

Re: Review Request 64234: Extract a storage Persistence layer

> On Dec. 1, 2017, 1:05 a.m., Stephan Erb wrote: > > This looks like a good improvement to me. Thanks! > > > > One general note: We have to ensure that > > https://github.com/apache/aurora/blob/master/docs/operations/storage.md > > will be up to date eventually. This does not need to happen

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192452 --- This looks like a good improvement to me. Thanks! One general

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192446 --- Ship it! Master (de8b375) is green with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192444 --- @ReviewBot retry - Bill Farner On Nov. 30, 2017, 4:32 p.m.,

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192443 --- Master (de8b375) is red with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

> On Nov. 30, 2017, 5:17 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/TransactionRecorder.java > > Lines 55 (patched) > > > > > > seems sufficiently complex to warrant

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192438 --- Ship it! Master (de8b375) is green with this patch.

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192416 --- Only had a quick look but I really like the abstractions created

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192418 --- Ship it! LGTM! This is a lot easier to reason about than the

Re: Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/#review192415 --- Reviewer notes.

Review Request 64234: Extract a storage Persistence layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64234/ --- Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.