Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review194029 --- Ship it! Thanks again for the patch. Committing this shortly.

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review194028 --- Ship it! Master (2e1ca42) is green with this patch.

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-17 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/ --- (Updated Dec. 17, 2017, 3:24 p.m.) Review request for Aurora, David

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193801 --- I am traveling for the next 5 days, so my review will be delayed.

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193738 --- Ship it! LGTM! Just one nit with come redundant lines in the

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193619 --- Ship it! Master (65c2288) is green with this patch.

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193618 --- @ReviewBot retry - Stephan Erb On Dec. 11, 2017, 12:13 p.m.,

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review193431 --- I have filed https://issues.apache.org/jira/browse/AURORA-1961 to

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-11 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/ --- (Updated Dec. 11, 2017, 11:13 a.m.) Review request for Aurora, David

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-10 Thread Jing Chen
> On Dec. 5, 2017, 6:30 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/config/test_thrift.py > > Lines 236-239 (patched) > > > > > > Please replace this with a direct equality comparison to the expected

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review192889 --- Thanks for the patch! RELEASE-NOTES.md Lines 50 (patched)

Re: Review Request 64341: Add metadata field to Job object in DSL

2017-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/#review192878 --- Ship it! Master (a0628ef) is green with this patch.

Review Request 64341: Add metadata field to Job object in DSL

2017-12-05 Thread Jing Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64341/ --- Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.