Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199774 --- Ship it! Ship It! - Stephan Erb On March 21, 2018, 9:23

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199702 --- Ship it! Master (f32086d) is green with this patch.

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-21 Thread Jordan Ly
> On March 21, 2018, 12:10 a.m., Jordan Ly wrote: > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > > Lines 386-387 (original), 386-387 (patched) > > > > > > Changed these values to be a bit

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-21 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/ --- (Updated March 21, 2018, 8:23 p.m.) Review request for Aurora, David

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-21 Thread David McLaughlin
> On March 21, 2018, 12:10 a.m., Jordan Ly wrote: > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > > Lines 386-387 (original), 386-387 (patched) > > > > > > Changed these values to be a bit

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199636 --- Ship it! Ship It! - David McLaughlin On March 21, 2018,

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-20 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199628 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 20,

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/#review199625 --- Ship it! Master (b3fa9fe) is green with this patch.

Re: Review Request 66190: Fix 'PreemptorSlotSearchBenchmark', remove 'isProduction' references in benchmark

2018-03-20 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66190/ --- (Updated March 21, 2018, 12:26 a.m.) Review request for Aurora, David