Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-31 Thread Kevin Sweeney
> On Jan. 24, 2014, 2:35 p.m., Kevin Sweeney wrote: > > Why is this happening on a role noun and not a quota noun. > > > > i.e. > > > > aurora quota get west/ksweeney > > > > v.s. > > > > aurora role get_quota west/ksweeney > > > > The second looks inconsistent with the noun-verb model to me

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-31 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33364 --- the rest of the review lgtm examples/vagrant/provision-aurora-sche

Re: Review Request 17270: Bridge framework for client v2.

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33360 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:03 p.m., Mark Chu-Ca

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33359 --- ping? - Mark Chu-Carroll On Jan. 30, 2014, 4:09 p.m., Mark Chu-Ca

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33358 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 31, 2014, 2:52 p.m.

Re: Review Request 17614: Fix whitespace glitches I missed in review.

2014-01-31 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17614/#review33355 --- Ship it! Ship It! - Jake Farrell On Jan. 31, 2014, 8:25 p.m., Ma

Review Request 17614: Fix whitespace glitches I missed in review.

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17614/ --- Review request for Aurora and Jake Farrell. Repository: aurora Description --

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 7:52 p.m.) Review request for Aurora and Mark Chu-Carro

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33345 --- src/main/python/apache/aurora/client/commands/admin.py

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33344 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 31, 2014, 2:34 p.m.

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 7:34 p.m.) Review request for Aurora and Mark Chu-Carro

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 6:46 p.m.) Review request for Aurora and Mark Chu-Carro

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-31 Thread Mark Chu-Carroll
> On Jan. 24, 2014, 5:35 p.m., Kevin Sweeney wrote: > > Why is this happening on a role noun and not a quota noun. > > > > i.e. > > > > aurora quota get west/ksweeney > > > > v.s. > > > > aurora role get_quota west/ksweeney > > > > The second looks inconsistent with the noun-verb model to me