Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-03 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/ --- (Updated Feb. 3, 2014, 3:58 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33429 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 11:30 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33435 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 3, 2014, 10:58

Re: Review Request 17637: AURORA-88: get_quota -h lists --cluster as deprecated

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17637/#review33436 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 3, 2014, 3:58

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33450 --- Ship it! Looks like Mark merged this to master, it's 4abccc3.

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33452 --- src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33462 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 10:16 a.m.,

Re: Review Request 17060: Fix noisy status checker debug log.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17060/#review33463 --- Ship it! Ship It! - Kevin Sweeney On Jan. 17, 2014, 11:06 a.m.,

Re: Review Request 17270: Bridge framework for client v2.

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33471 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2014, 9:03 p.m.,

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33476 --- examples/vagrant/provision-dev-environment.sh

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33475 --- examples/vagrant/provision-mesos-slave.sh

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 3:16 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 17056: fix dependencies for setup_py

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33495 --- src/main/python/apache/aurora/client/BUILD

Review Request 17672: Add indices to OfferQueueImpl to improve resource offer handling performance.

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17672/ --- Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs:

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Maxim Khutornenko
On Feb. 3, 2014, 7:22 p.m., Bill Farner wrote: You might want to do a bit more in this commit, specifically to ensure read sites handle the new state. You probably also want to rewrite the state in StorageBackfill. Also look out for another regression like

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- (Updated Feb. 3, 2014, 8:44 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
On Feb. 3, 2014, 4:47 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-environment.sh, line 5 https://reviews.apache.org/r/17457/diff/4/?file=463503#file463503line5 git is already on this commandline and setuptools shouldn't be needed. From the virtualbox environment

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
On Feb. 3, 2014, 1:47 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-environment.sh, line 5 https://reviews.apache.org/r/17457/diff/4/?file=463503#file463503line5 git is already on this commandline and setuptools shouldn't be needed. From the virtualbox environment

Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Kevin Sweeney
On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote: Suman Karumuri wrote: Spoke to Bill before making these changes. We decided to use getInfo API and deprecate getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future it may include other

Review Request 17680: Break down free slots stats into dedicated and shared.

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17680/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-152

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/ --- (Updated Feb. 3, 2014, 6:43 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33530 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 3:43 p.m.,

Re: Review Request 17689: Fixing submit instructions.

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17689/#review33558 --- Thanks. Pushed. - Maxim Khutornenko On Feb. 4, 2014, 2 a.m.,