Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

> On May 1, 2014, 8:59 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/job_monitor.py, line 81 > > > > > > >= > > Maxim Khutornenko wrote: > It's safe as is but since Mark asked about this t

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

> On May 1, 2014, 8:59 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/job_monitor.py, line 81 > > > > > > >= It's safe as is but since Mark asked about this too changing it for better readabil

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/ --- (Updated May 1, 2014, 10:21 p.m.) Review request for Aurora, Mark Chu-Carroll a

Review Request 20986: Adding min_instance_count threshold to improve safe domain results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20986/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-305 https://issue

Re: Review Request 20928: Command hooks: stage 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/#review41958 --- Ship it! lgtm - David McLaughlin On May 1, 2014, 9:39 p.m., Mark

Re: Review Request 20928: Command hooks: stage 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/ --- (Updated May 1, 2014, 5:39 p.m.) Review request for Aurora, David McLaughlin an

Re: Review Request 20928: Command hooks: stage 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/#review41951 --- docs/design/command-hooks.md

Re: Review Request 20928: Command hooks: stage 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/#review41945 --- docs/design/command-hooks.md

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41947 --- src/main/python/apache/aurora/client/api/job_monitor.py

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/ --- (Updated May 1, 2014, 8:42 p.m.) Review request for Aurora, Mark Chu-Carroll an

Re: Review Request 20928: Command hooks: stage 2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/ --- (Updated May 1, 2014, 4:47 p.m.) Review request for Aurora, David McLaughlin an

Re: Review Request 20723: Add batch options to kill and killall.

> On April 25, 2014, 3:18 p.m., David McLaughlin wrote: > > lgtm ping, suman? - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/#review41509 ---

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41943 --- Ship it! Ship It! - Mark Chu-Carroll On May 1, 2014, 4:42 p.m.,

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

> On May 1, 2014, 7:44 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/job_monitor.py, line 81 > > > > > > shouldn't this be >=? Line 84 guarantees it never exceeds the max value: poll_inter

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41938 --- src/main/python/apache/aurora/client/api/job_monitor.py

Review Request 20959: Moving kill wait to the client (Part 2: server changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20959/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-370 https://issues.

Review Request 20950: Moving kill wait to the client (Part 1: client changes)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-370