Review Request 21980: Fix client logging.

2014-05-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: aurora-473

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/ --- (Updated May 28, 2014, 12:02 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21951/#review44123 --- src/main/java/org/apache/aurora/scheduler/http/Utilization.java

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread Bill Farner
On May 28, 2014, 4:26 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/http/Utilization.java, line 164 https://reviews.apache.org/r/21951/diff/1/?file=595644#file595644line164 Do we really want to start using Locale everywhere when dealing with string

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread Maxim Khutornenko
On May 28, 2014, 4:26 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/http/Utilization.java, line 164 https://reviews.apache.org/r/21951/diff/1/?file=595644#file595644line164 Do we really want to start using Locale everywhere when dealing with string

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21951/#review44141 --- Ship it! - David McLaughlin On May 28, 2014, 12:57 a.m., Bill

Re: Review Request 21828: Use asynchronous transport in Thrift.js client

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21828/#review44142 --- Ping. - David McLaughlin On May 22, 2014, 9:31 p.m., David

Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21791/#review44143 --- Ping. This can be shipped to master. - David McLaughlin On May

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/#review44144 --- I don't have all the context, but it seems unusual to me to add a

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/ --- (Updated May 28, 2014, 6:52 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/ --- (Updated May 28, 2014, 6:53 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread David McLaughlin
On May 28, 2014, 6:49 p.m., David McLaughlin wrote: I don't have all the context, but it seems unusual to me to add a log level for this use case. Can you explain a little why this is needed? Mark Chu-Carroll wrote: Sure. We're trying to create a centralized logging/analytics

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread Mark Chu-Carroll
On May 28, 2014, 2:49 p.m., David McLaughlin wrote: I don't have all the context, but it seems unusual to me to add a log level for this use case. Can you explain a little why this is needed? Mark Chu-Carroll wrote: Sure. We're trying to create a centralized logging/analytics

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/#review44150 --- Ship it! - David McLaughlin On May 28, 2014, 4:02 p.m., Mark

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/#review44149 --- Ship it! - David McLaughlin On May 28, 2014, 4:02 p.m., Mark

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ --- (Updated May 28, 2014, 7:25 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-28 Thread Suman Karumuri
On May 28, 2014, 6:42 p.m., David McLaughlin wrote: Ping. This can be shipped to master. Can you please rebase with master. - Suman --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 21828: Use asynchronous transport in Thrift.js client

2014-05-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21828/#review44175 --- Pushed to master. Please close out this review. - Suman Karumuri

Review Request 21994: Fixing incorrect .gitignore rule.

2014-05-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-485

Re: Review Request 21994: Fixing incorrect .gitignore rule.

2014-05-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/#review44192 --- Ship it! - Kevin Sweeney On May 28, 2014, 3:40 p.m., Suman

Re: Review Request 21943: Accept a job key for config loading.

2014-05-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21943/#review44210 --- Ship it! Thank you for this! Long overdue; I've been meaning to

Re: Review Request 21994: Fixing incorrect .gitignore rule.

2014-05-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/#review44214 --- .gitignore https://reviews.apache.org/r/21994/#comment78557

Re: Review Request 21980: Fix client logging.

2014-05-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/#review44215 --- Ship it! src/main/python/apache/aurora/client/cli/BUILD