Re: Review Request 21402: Add python checkstyle hooks.

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402/#review46638 --- Ship it! Looks good, please create a ticket to capture the log

Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

2014-06-25 Thread Jake Farrell
On April 25, 2014, 4:06 a.m., Bill Farner wrote: I have some reservations with this, but they're not well-formed. I like the idea of giving committers a chance to chime in on reviews, and we seem to be building process around reviewboard for that. We also have plans to build test

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-25 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- (Updated June 25, 2014, 12:38 p.m.) Review request for Aurora, David

Re: Review Request 22457: Improve aurora job diff command.

2014-06-25 Thread Maxim Khutornenko
On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181 I don't think it's enough to json-serialize a thrift task. This is bound to set/dict

Re: Review Request 22457: Improve aurora job diff command.

2014-06-25 Thread Mark Chu-Carroll
On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181 I don't think it's enough to json-serialize a thrift task. This is bound to set/dict

Review Request 22976: AURORA-552: License headers missing

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22976/ --- Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Bill Farner.

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

2014-06-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 25, 2014, 6:48 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22976: AURORA-552: License headers missing

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22976/ --- (Updated June 25, 2014, 7:09 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 22976: AURORA-552: License headers missing

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22976/#review46663 --- Ship it! Ship It! - Bill Farner On June 25, 2014, 7:09 p.m.,

Re: Review Request 22457: Improve aurora job diff command.

2014-06-25 Thread Maxim Khutornenko
On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181 I don't think it's enough to json-serialize a thrift task. This is bound to set/dict

Re: Review Request 22976: AURORA-552: License headers missing

2014-06-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22976/#review46664 --- Ship it! Ship It! - Kevin Sweeney On June 25, 2014, 12:09 p.m.,

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22697/#review46667 --- Ship it! Ship It! - Bill Farner On June 25, 2014, 4:48 p.m.,

Re: Review Request 22956: AURORA-231: Licence plugin is noisy

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22956/#review46669 --- Ship it! Review workflow pedantry, but can you change the review

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22697/#review46670 --- Ship it! Awesome, thanks Maxim! docs/sla.md

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Maxim Khutornenko
On June 25, 2014, 7:26 p.m., Joe Smith wrote: docs/sla.md, line 82 https://reviews.apache.org/r/22697/diff/2/?file=617031#file617031line82 This is a purely Done. On June 25, 2014, 7:26 p.m., Joe Smith wrote: docs/sla.md, line 102

Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Review Request 22983: AURORA-278 - Remove binaries from source RC

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs:

Re: Review Request 21459: Database-backed implementation of QuotaStore.

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/#review46681 --- Ping - needing a review from Kevin. - Bill Farner On June 23,

Re: Review Request 22983: AURORA-278 - Remove binaries from source RC

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/#review46679 --- .gitattributes https://reviews.apache.org/r/22983/#comment82220

Re: Review Request 21459: Database-backed implementation of QuotaStore.

2014-06-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21459/#review46686 --- Ship it! Ship It! - Kevin Sweeney On June 23, 2014, 2:23 p.m.,

Re: Review Request 21440: Implementing parallel updater

2014-06-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review46692 --- src/main/python/apache/aurora/client/api/instance_watcher.py

Re: Review Request 22457: Improve aurora job diff command.

2014-06-25 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 25, 2014, 9:16 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22956: AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22956/ --- (Updated June 26, 2014, 2:28 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution

2014-06-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19796/ --- (Updated June 26, 2014, 3:23 a.m.) Review request for Aurora, Kevin Sweeney

Review Request 22998: Generate wrapper classes for all thrift structs in api.thrift.

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22998/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Review Request 22999: Use immutable types in AttributeStore.

2014-06-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository: