Re: Review Request 22457: Improve aurora job diff command.

2014-07-17 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated July 17, 2014, 10:09 a.m.) Review request for Aurora, Maxim

Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/#review48022 --- 'Fat jars' are inherently problematic. Some libraries expect

Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Jake Farrell
On July 17, 2014, 5:33 p.m., Bill Farner wrote: 'Fat jars' are inherently problematic. Some libraries expect resources at well-known locations, which would be candidate for brittleness when there are collisions. Jar signing is also broken by this approach. Unless there's a

Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23595/#review48027 --- Thanks for the gut check, discarding this review. - Kevin Sweeney

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

2014-07-17 Thread Bjoern Metzdorf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 17, 2014, 6:11 p.m.) Review request for Aurora and Kevin

Review Request 23653: Fix log error causing new slave attributes to be discarded.

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23653/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-582

Re: Review Request 23105: Database-backed implementation of AttributeStore.

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23105/ --- (Updated July 17, 2014, 9:49 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review48074 --- Kevin - ping? - Bill Farner On July 2, 2014, 1:33 a.m., Bill

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

2014-07-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48075 --- Ship it! Ship It! - Joe Smith On July 14, 2014, 10:50 a.m.,

Review Request 23667: Fix release-candidate script to use apache-aurora-*

2014-07-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23667/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 23667: Fix release-candidate script to use apache-aurora-*

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23667/#review48082 --- Ship it! Ship It! - Bill Farner On July 17, 2014, 10:49 p.m.,

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- (Updated July 17, 2014, 10:53 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-17 Thread Misho Krastev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23666/ --- (Updated July 17, 2014, 11:16 p.m.) Review request for Aurora. Repository: