Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

> On Oct. 18, 2014, 12:50 a.m., Bill Farner wrote: > > Thanks, great idea? Whoops, should have read "Thanks, great idea!" :-) - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26902/#re

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26902/#review57256 --- Thanks, great idea? buildSrc/src/main/groovy/org/apache/aurora/Cov

Re: Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26902/#review57254 --- Ship it! Ship It! - Kevin Sweeney On Oct. 17, 2014, 5:26 p.m., J

Review Request 26902: Add a message when coverage exceeds minimum. This way we'll be sure to continually raise the minimum threshold as we exceed it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26902/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26901/#review57253 --- Ship it! Thanks! This is now on master. $ git log -1 origin/m

Re: Review Request 26836: Cron documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26836/#review57252 --- Sorry Jay, I'll address your feedback in a subsequent review. - Kev

Re: Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26901/#review57249 --- Ship it! Ship It! - Kevin Sweeney On Oct. 17, 2014, 4:47 p.m., J

Re: Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26901/ --- (Updated Oct. 17, 2014, 11:47 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26901/#review57247 --- Ship it! LGTM once terminology is swapped so "penalty" applies afte

Review Request 26901: Decouple initial scheduling delay from first scheduling penalty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26901/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-868

Re: Review Request 26852: Use mesos.native egg from ~kevints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/#review57246 --- Looks like this egg is affected by https://issues.apache.org/jira/b

Review Request 26899: Require StateManager callers to open their own transactions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26899/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur

Re: Review Request 26856: Adding storage configuration summary.

> On Oct. 17, 2014, 9:34 p.m., Kevin Sweeney wrote: > > Can you merge docs/scheduler-storage.md with this one? Also, filename nit: > > we've used dash instead of underscore elsewhere, mind keeping that > > convention here? Agree, no reason to keep them separate. Merged and discarded this revie

Re: Review Request 26851: Adding storage recovery from backup doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26851/ --- (Updated Oct. 17, 2014, 9:47 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26856: Adding storage configuration summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26856/#review57223 --- Can you merge docs/scheduler-storage.md with this one? Also, filenam

Re: Review Request 26856: Adding storage configuration summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26856/ --- (Updated Oct. 17, 2014, 9:18 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26856: Adding storage configuration summary.

> On Oct. 17, 2014, 2:46 p.m., Jay Buffington wrote: > > docs/storage_config.md, line 2 > > > > > > A summary here would be good to help give an overview of what the point > > of this document is and who the intended au

Re: Review Request 26383: Health Check Disabler

> On Oct. 17, 2014, 7:30 p.m., David Pan wrote: > > Ship It! This is on master. Thanks! - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review57199

Re: Review Request 26851: Adding storage recovery from backup doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26851/ --- (Updated Oct. 17, 2014, 8:45 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26851: Adding storage recovery from backup doc.

> On Oct. 17, 2014, 5:07 p.m., Bill Farner wrote: > > docs/storage_recovery.md, line 1 > > > > > > How about: "Recovering from a scheduler backup" Done. > On Oct. 17, 2014, 5:07 p.m., Bill Farner wrote: > > docs/stora

Re: Review Request 26383: Health Check Disabler

> On Oct. 17, 2014, 12:18 p.m., Maxim Khutornenko wrote: > > Ship It! Bill Farner mentioned that once you give a shipit, it is good to go (and that he is not needed for the review). Is it okay if you commit the change? Thanks! - David --

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

> On Oct. 16, 2014, 8:11 p.m., Kevin Sweeney wrote: > > Is this still needed? I thought the checkstyle check was updated > > Zameer Manji wrote: > I was under this impression as well. Ok, discarded. - Joshua --- This is an automati

Re: Review Request 26834: Add client cluster configuration docs.

> On Oct. 17, 2014, 3:02 p.m., Jay Buffington wrote: > > docs/client-cluster-configuration.md, line 63 > > > > > > I this true? It was my understanding that the only use for this field > > is to format URLs that are

Re: Review Request 26834: Add client cluster configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/ --- (Updated Oct. 17, 2014, 8:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57206 --- Maybe this is nitpicking, but given the confusion we've already seen

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/ --- (Updated Oct. 17, 2014, 8:02 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 26753: Start removing clientv1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753/#review57203 --- Ping? - Bill Farner On Oct. 15, 2014, 4:20 p.m., Mark Chu-Carroll

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review57199 --- Ship it! Ship It! - David Pan On Oct. 17, 2014, 12:26 p.m., Davi

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 17, 2014, 12:26 p.m.) Review request for Aurora, Joe Smith, Maxim

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review57197 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 17, 2014, 6:28 p.m

Re: Review Request 26841: Describe how to clone the git repo to contributing docs.

> On Oct. 17, 2014, 12:21 a.m., Maxim Khutornenko wrote: > > Ship It! Maxim - can you commit this? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26841/#review57069 --

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 17, 2014, 11:28 a.m.) Review request for Aurora, Joe Smith, Maxim

Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: aurora-771 h

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review57177 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 8, 2014, 7:46 p.m.,

Re: Review Request 26852: Use mesos.native egg from ~kevints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/#review57170 --- examples/vagrant/provision-dev-cluster.sh

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review57163 --- src/main/python/apache/aurora/executor/common/health_checker.py

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 17, 2014, 10:09 a.m.) Review request for Aurora, Joe Smith, Maxim

Re: Review Request 26851: Adding storage recovery from backup doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26851/#review57160 --- docs/storage_recovery.md

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review57164 --- Ship it! Ship It! - Joe Smith On Oct. 17, 2014, 8:48 a.m., Maxim

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26664/ --- (Updated Oct. 17, 2014, 4:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.

> On Oct. 15, 2014, 12:41 a.m., Bill Farner wrote: > > src/main/python/apache/aurora/executor/gc_executor.py, line 281 > > > > > > More context? It's not clear what you mean here. Added. > On Oct. 15, 2014, 12:41 a

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/ --- (Updated Oct. 17, 2014, 3:48 p.m.) Review request for Aurora, Joe Smith and Bri

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

> On Oct. 15, 2014, 7:04 p.m., Joe Smith wrote: > > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 206 > > > > > > mock_wait.assert_called_once_with Added. - Maxim

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

> On Oct. 15, 2014, 6:08 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 41 > > > > > > minor nit: > > Amount(5, Time.MINUTES) Done. - Maxim

Re: Review Request 26836: Cron documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26836/#review57144 --- docs/cron-jobs.md

Re: Review Request 26845: Adding Aurora scheduler storage doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26845/#review57143 --- Ship it! Sorry for the late review after it already merged. This d

Re: Review Request 26834: Add client cluster configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57142 --- docs/client-cluster-configuration.md

Re: Review Request 26822: Fix table of contents in configuration-tutorial.md

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26822/#review57141 --- Ship it! Thanks! That always bugged me! - Jay Buffington On Oct

Re: Review Request 26856: Adding storage configuration summary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26856/#review57139 --- docs/storage_config.md