On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote:
docs/deploying-aurora-scheduler.md, line 163
https://reviews.apache.org/r/28920/diff/18/?file=823201#file823201line163
Philosophical question: if there's already a hard requirement that the
container have Python 2.7 why not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69269
---
I think we should leave the yaml code but drop the PyYAML
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69268
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 22, 2015, 1:09 p.m.,
On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review69276
---
Ping - Kevin?
- Bill Farner
On Jan. 8, 2015, 5:25 p.m., Steve
On Jan. 22, 2015, 1:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69282
---
src/main/python/apache/thermos/core/runner.py
On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote:
docs/deploying-aurora-scheduler.md, line 163
https://reviews.apache.org/r/28920/diff/18/?file=823201#file823201line163
Philosophical question: if there's already a hard requirement that the
container have Python 2.7 why not
On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote:
src/main/python/apache/thermos/core/runner.py, lines 627-632
https://reviews.apache.org/r/28920/diff/18/?file=823218#file823218line627
this is an abstraction leak. grep the thermos codebase for 'aurora'
and 'mesos'. thermos
On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote:
src/main/python/apache/thermos/core/runner.py, lines 627-632
https://reviews.apache.org/r/28920/diff/18/?file=823218#file823218line627
this is an abstraction leak. grep the thermos codebase for 'aurora'
and 'mesos'. thermos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30203/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30204/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30204/
---
(Updated Jan. 23, 2015, 2:11 a.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69333
---
On Jan. 23, 2015, 2:43 a.m., Jay Buffington wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line
294
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line294
Can you set force_pull_image to true here. I can't imagine why you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/
---
(Updated Jan. 23, 2015, 2:55 vorm.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30207/
---
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review69346
---
Master (3fa004b) is red with this patch.
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
On Jan. 21, 2015, 6:35 p.m., Kevin Sweeney wrote:
examples/vagrant/provision-dev-cluster.sh, line 17
https://reviews.apache.org/r/28920/diff/18/?file=823204#file823204line17
nit: sh -c indirection is unnecessary here.
Steve Niemitz wrote:
Eh, this is just copied from the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69288
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29464/#review69306
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 8, 2015, 9:25 a.m.,
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/#review69236
---
Ship it!
Master (116ee2d) is green with this patch.
On Jan. 22, 2015, 7:43 p.m., Kevin Sweeney wrote:
We've explored this in the past, but how about moving the authentication
code to a decorator class and delegating the behavior-once-authenticated.
Maxim Khutornenko wrote:
We have a TODO tracking this:
```
// TODO(Sathya):
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/#review69232
---
We've explored this in the past, but how about moving the
On Jan. 22, 2015, 7:43 p.m., Kevin Sweeney wrote:
We've explored this in the past, but how about moving the authentication
code to a decorator class and delegating the behavior-once-authenticated.
We have a TODO tracking this:
```
// TODO(Sathya): Remove this after AOP-style session
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/#review69243
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 22, 2015, 11:25 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/
---
(Updated Jan. 22, 2015, 7:25 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30178/#review69231
---
Ship it!
On Jan. 22, 2015, 7:38 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 711
https://reviews.apache.org/r/30178/diff/1/?file=830099#file830099line711
This is only used in one place, inline?
I pulled this out
On Jan. 22, 2015, 11:43 a.m., Kevin Sweeney wrote:
We've explored this in the past, but how about moving the authentication
code to a decorator class and delegating the behavior-once-authenticated.
Maxim Khutornenko wrote:
We have a TODO tracking this:
```
//
On Jan. 22, 2015, 7:43 p.m., Kevin Sweeney wrote:
We've explored this in the past, but how about moving the authentication
code to a decorator class and delegating the behavior-once-authenticated.
Maxim Khutornenko wrote:
We have a TODO tracking this:
```
// TODO(Sathya):
36 matches
Mail list logo
