Re: Review Request 31774: Add aurora-specific entry point for thermos observer and fix /vars

2015-03-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31774/#review75410 --- Master (70494a1) is green with this patch.

Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31779/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/#review75413 --- Ship it! Master (70494a1) is green with this patch.

Re: Review Request 31753: Add storage support for associating a message with job update events.

2015-03-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31753/#review75405 --- Ship it! Master (70494a1) is green with this patch.

Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/ --- (Updated March 5, 2015, 6:48 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-05 Thread Maxim Khutornenko
On March 3, 2015, 11:56 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 237 https://reviews.apache.org/r/31652/diff/1/?file=882474#file882474line237 s/taskId/groupKey/ Good catch, fixed. On March 3, 2015, 11:56 p.m., Bill Farner

Re: Review Request 31646: Moving GroupKey to scheduler.base.

2015-03-05 Thread Maxim Khutornenko
On March 3, 2015, 11:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java, line 23 https://reviews.apache.org/r/31646/diff/1/?file=882425#file882425line23 s/Identifying/Identifer for/ It's not until reading this diff that i wonder

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
On March 4, 2015, 7:18 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 141 https://reviews.apache.org/r/31754/diff/1/?file=885268#file885268line141 There seems to be implementation detail leaking here. Can you make JettyServerModule