Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/ --- (Updated March 7, 2014, 5:20 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-05 Thread Joe Smith
On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote: src/test/python/apache/aurora/client/commands/test_maintenance.py, line 136 https://reviews.apache.org/r/18334/diff/3/?file=502376#file502376line136 Not sure how I feel about this style of mock - I'd prefer the class under test to

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-03 Thread Joe Smith
On Feb. 24, 2014, 6:36 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/admin/mesos_maintenance.py, line 73 https://reviews.apache.org/r/18334/diff/3/?file=502368#file502368line73 Inclined to revert this - better to explicitly call out a dependency on system time IMO.

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/ --- (Updated March 3, 2014, 6:50 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35152 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 20, 2014, 7:05