Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Brian Wickman
On May 1, 2014, 8:59 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/job_monitor.py, line 81 https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81 = Maxim Khutornenko wrote: It's safe as is but since Mark asked about this too changing it

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review42025 --- Ship it! Ship It! - Brian Wickman On May 1, 2014, 10:21 p.m.,

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41938 --- src/main/python/apache/aurora/client/api/job_monitor.py

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Maxim Khutornenko
On May 1, 2014, 7:44 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/job_monitor.py, line 81 https://reviews.apache.org/r/20950/diff/1/?file=572657#file572657line81 shouldn't this be =? Line 84 guarantees it never exceeds the max value: poll_interval =

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41943 --- Ship it! Ship It! - Mark Chu-Carroll On May 1, 2014, 4:42 p.m.,

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/ --- (Updated May 1, 2014, 8:42 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review41947 --- src/main/python/apache/aurora/client/api/job_monitor.py

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Maxim Khutornenko
On May 1, 2014, 8:59 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/job_monitor.py, line 81 https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81 = It's safe as is but since Mark asked about this too changing it for better readability. On

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/ --- (Updated May 1, 2014, 10:21 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Brian Wickman
On May 1, 2014, 8:59 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/job_monitor.py, line 81 https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81 = Maxim Khutornenko wrote: It's safe as is but since Mark asked about this too changing it