On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 385
https://reviews.apache.org/r/21247/diff/1/?file=577123#file577123line385
please only pass the required fields into the fields into the function.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 15, 2014, 9:47 p.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review43180
---
This diff is merged. Please close out this review and the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42980
---
Ship it!
Ship It!
- Suman Karumuri
On May 14, 2014, 3:46 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42626
---
I think we should show the config bar even when there is one
On May 14, 2014, 4:26 a.m., Suman Karumuri wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 386
https://reviews.apache.org/r/21247/diff/5/?file=581259#file581259line386
I see this function call (function definition itself is good) as a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 14, 2014, 3:46 p.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42981
---
Thanks for the changes.
- Suman Karumuri
On May 14, 2014, 3:46
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
I think we should show the config bar even when there is one config. It
will also act a visual indication to the user that all his tasks are in a
consistent config.
This is a fair suggestion, and I tried this initially. Having a 100%
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 14, 2014, 1:30 a.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42937
---
This looks really good. Thanks for the changes. The only ship it
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html,
line 6
https://reviews.apache.org/r/21247/diff/1/?file=577121#file577121line6
Please make this an abbr and add the label to the tooltip also. If
there
On May 9, 2014, 10:27 p.m., Bill Farner wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html,
line 21
https://reviews.apache.org/r/21247/diff/1/?file=577121#file577121line21
kill extra newline
done.
On May 9, 2014, 10:27 p.m., Bill Farner wrote:
On May 9, 2014, 10:27 p.m., Bill Farner wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 400
https://reviews.apache.org/r/21247/diff/1/?file=577123#file577123line400
s/if(/if (/
David McLaughlin wrote:
done. would be nice to have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 12, 2014, 6:50 p.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 12, 2014, 8:27 p.m.)
Review request for Aurora, Suman Karumuri
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
I think we should show the config bar even when there is one config. It
will also act a visual indication to the user that all his tasks are in a
consistent config.
David McLaughlin wrote:
This is a fair suggestion, and I tried
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html,
line 1
https://reviews.apache.org/r/21247/diff/1/?file=577119#file577119line1
wrap this in a div.
David McLaughlin wrote:
Why?
Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42759
---
Also, please think of a way to test this locally.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 13, 2014, 12:02 a.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42617
---
Ship it!
21 matches
Mail list logo
