Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/ --- (Updated Oct. 24, 2014, 8:09 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58376 --- Ship it! Ship It! - Zameer Manji On Oct. 24, 2014, 1:09 p.m.,

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58403 --- -1: Master (5be667f) is red with this patch.

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/ --- (Updated Oct. 24, 2014, 10:48 p.m.) Review request for Aurora, Mark

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58420 --- Ship it! Long live ReviewBot! - Kevin Sweeney On Oct. 24, 2014,

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58444 --- -1: Master (3778330) is red with this patch.

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/ --- (Updated Oct. 25, 2014, 12:24 a.m.) Review request for Aurora, Mark

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin
On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252 https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252 I don't think this needs to be a mock at all - I'm pretty sure that you can just

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin
On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252 https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252 I don't think this needs to be a mock at all - I'm pretty sure that you can just

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/ --- (Updated Oct. 23, 2014, 9:47 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58120 --- Ship it! Ship It! - Kevin Sweeney On Oct. 23, 2014, 2:47 p.m.,

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin
On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252 https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252 I don't think this needs to be a mock at all - I'm pretty sure that you can just

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58205 --- This patch does not apply cleanly on master (53f4e73), do you need

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review57936 --- src/test/python/apache/aurora/client/cli/test_diff.py

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-22 Thread Maxim Khutornenko
On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252 https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252 I don't think this needs to be a mock at all - I'm pretty sure that you can just

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-22 Thread Joe Smith
On Oct. 22, 2014, 4:24 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252 https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252 I don't think this needs to be a mock at all - I'm pretty sure that you can just