Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62577 ---

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/ --- (Updated Nov. 21, 2014, 6:28 p.m.) Review request for Aurora, Maxim

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62585 --- Master (ada97bd) is red with this patch.

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62590 --- Ship it!

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62596 --- Ship it! Ship It! - Zameer Manji On Nov. 21, 2014, 10:28 a.m.,

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62594 --- Ship it! Ship It! - Joshua Cohen On Nov. 21, 2014, 6:28 p.m.,

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/ --- (Updated Nov. 21, 2014, 7:42 p.m.) Review request for Aurora, Maxim

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62613 --- This patch does not apply cleanly on master (b6217df), do you need

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Maxim Khutornenko
On Nov. 21, 2014, 6:48 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 301 https://reviews.apache.org/r/28310/diff/3/?file=772285#file772285line301 newline? Bill Farner wrote: Not sure what you're requesting here. Where

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Bill Farner
On Nov. 21, 2014, 6:48 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 301 https://reviews.apache.org/r/28310/diff/3/?file=772285#file772285line301 newline? Bill Farner wrote: Not sure what you're requesting here. Where

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/ --- (Updated Nov. 21, 2014, 9:09 p.m.) Review request for Aurora, Maxim

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62648 --- Master (6f92724) is red with this patch.

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/ --- (Updated Nov. 21, 2014, 2:17 a.m.) Review request for Aurora, Maxim

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/ --- (Updated Nov. 21, 2014, 2:18 a.m.) Review request for Aurora, Maxim

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62509 --- Master (ada97bd) is red with this patch.

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28310/#review62521 --- You forgot to add the ClusterState implementation to your diff. -

Re: Review Request 28310: Extract a cluster state abstraction from PreemptorImpl.

2014-11-20 Thread Zameer Manji
On Nov. 20, 2014, 8:39 p.m., Zameer Manji wrote: You forgot to add the ClusterState implementation to your diff. And by implementation I mean interface. - Zameer --- This is an automatically generated e-mail. To reply, visit: