Re: Review Request 30710: add mesos role feature

On Feb. 17, 2015, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, line 114 https://reviews.apache.org/r/30710/diff/3/?file=861559#file861559line114 This is breaking Resources/Offer encapsulation and is not addressing

Re: Review Request 30710: add mesos role feature

On Feb. 17, 2015, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, line 114 https://reviews.apache.org/r/30710/diff/3/?file=861559#file861559line114 This is breaking Resources/Offer encapsulation and is not addressing

Re: Review Request 30710: add mesos role feature

On Feb. 17, 2015, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, line 174 https://reviews.apache.org/r/30710/diff/3/?file=861559#file861559line174 Prefer using guava `Ordering` [1] instead. It will avoid excessive

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review72113 --- Ship it! Master (61e6c35) is green with this patch.

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/ --- (Updated Feb. 12, 2015, 6:12 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30710: add mesos role feature

On Feb. 9, 2015, 4:56 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, line 117 https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117 I don't think we can safely do this right now. I know the

Re: Review Request 30710: add mesos role feature

On Feb. 10, 2015, 12:56 a.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, line 117 https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117 I don't think we can safely do this right now. I know the

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71754 ---

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71727 ---

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/ --- (Updated Feb. 9, 2015, 4:01 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71407 --- Ship it! Master (5059040) is green with this patch.

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/ --- (Updated Feb. 6, 2015, 9:23 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30710: add mesos role feature

On Feb. 6, 2015, 7:02 a.m., Aurora ReviewBot wrote: Master (5059040) is red with this patch. ./build-support/jenkins/build.sh 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain[ant:checkstyle]

Re: Review Request 30710: add mesos role feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30710/#review71386 --- Master (5059040) is red with this patch.