---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 10, 2015, 5:44 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75929
---
Ship it!
Master (48dc4c7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75980
---
src/main/python/apache/aurora/client/api/__init__.py
On March 11, 2015, 12:08 a.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 282
https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282
My understanding was that zmanji was attempting to remove
AuroraCommandContext and patch
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 282
https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282
My understanding was that zmanji was attempting to remove
AuroraCommandContext and patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review76007
---
Ship it!
LGTM once `self` or `cls` are used in place of class
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 11, 2015, 12:17 a.m.)
Review request for Aurora, Kevin Sweeney
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 282
https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282
My understanding was that zmanji was attempting to remove
AuroraCommandContext and patch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 11, 2015, 12:26 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review76019
---
Ship it!
Master (b53e023) is green with this patch.
On March 9, 2015, 8:17 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 679
https://reviews.apache.org/r/31869/diff/1/?file=889600#file889600line679
why not just context?
Done.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75762
---
src/main/python/apache/aurora/client/api/__init__.py
On March 9, 2015, 8:21 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/cli/test_create.py, line 277
https://reviews.apache.org/r/31869/diff/1/?file=889602#file889602line277
Use pytest.raises for tests where you expect an exception to be raised:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75765
---
Ship it!
Ship It!
- Zameer Manji
On March 9, 2015, 1:10 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75761
---
Ship it!
src/main/python/apache/aurora/client/cli/jobs.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75760
---
src/test/python/apache/aurora/client/cli/test_create.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 9, 2015, 8:39 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75812
---
src/main/python/apache/aurora/client/base.py
On March 9, 2015, 11:39 p.m., Kevin Sweeney wrote:
src/test/python/apache/aurora/client/cli/test_create.py, line 277
https://reviews.apache.org/r/31869/diff/2/?file=889611#file889611line277
You don't actually need to use the pytest API for this - since we're on
python 2.7 and you
19 matches
Mail list logo
