On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76094
---
Ship it!
LGTM modulo the outstanding question re: length limit.
-
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76150
---
Ship it!
Master (4ec563f) is green with this patch.
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76022
---
Ship it!
Master (b53e023) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76004
---
Ship it!
Ship It!
- David McLaughlin
On March 11, 2015, 12:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
12 matches
Mail list logo
