Re: Review Request 17303: Added getJobSummary API

2014-03-11 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated March 11, 2014, 6:22 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17303: Added getJobSummary API

2014-03-09 Thread Suman Karumuri
On March 3, 2014, 8:51 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 38 https://reviews.apache.org/r/17303/diff/3/?file=507562#file507562line38 s/Collection/Iterable/ Done. On March 3, 2014, 8:51 p.m., Bill Farner wrote:

Re: Review Request 17303: Added getJobSummary API

2014-03-09 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated March 9, 2014, 10:17 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17303: Added getJobSummary API

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/#review36023 --- Looking pretty good now, found a handful of places where comments

Re: Review Request 17303: Added getJobSummary API

2014-02-28 Thread Bill Farner
On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19 https://reviews.apache.org/r/17303/diff/1/?file=447781#file447781line19 Do you think this class scales to multiple consumers? i.e. there's a bunch of hard-coded

Re: Review Request 17303: Added getJobSummary API

2014-02-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/#review35831 --- src/main/java/org/apache/aurora/scheduler/base/Jobs.java

Re: Review Request 17303: Added getJobSummary API

2014-02-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated March 1, 2014, 1:26 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17303: Added getJobSummary API

2014-02-28 Thread Suman Karumuri
On Feb. 28, 2014, 8:21 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 2 https://reviews.apache.org/r/17303/diff/2/?file=504348#file504348line2 2014 Done. I wish the license plugin checked for things like these. On Feb. 28, 2014, 8:21

Re: Review Request 17303: Added getJobSummary API

2014-02-25 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated Feb. 26, 2014, 4:18 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17303: Added getJobSummary API

2014-02-25 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17303/ --- (Updated Feb. 26, 2014, 4:18 a.m.) Review request for Aurora, Kevin Sweeney