Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- (Updated May 27, 2014, 6:24 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-27 Thread Bill Farner
> On May 23, 2014, 6:53 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 45 > > > > > > Mixed final and non-final classes in this file - converge on one? > > Bill F

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- (Updated May 27, 2014, 6:08 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review44003 --- Ship it! - David McLaughlin On May 23, 2014, 8:26 p.m., Bill Farn

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review43976 --- Ship it! Ship It! - Maxim Khutornenko On May 23, 2014, 8:26 p.m.

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- (Updated May 23, 2014, 8:26 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-23 Thread Bill Farner
> On May 23, 2014, 6:53 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 45 > > > > > > Mixed final and non-final classes in this file - converge on one? Dropped th

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review43854 --- src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java <

Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository: