Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Maxim Khutornenko
On Sept. 2, 2014, 7:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 176 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line176 Nit - but why are you changing the parameter comment syntax? We don't use the double-dash

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Mark Chu-Carroll
On Sept. 2, 2014, 3:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 176 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line176 Nit - but why are you changing the parameter comment syntax? We don't use the double-dash

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25204/#review52214 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 29, 2014, 6:28

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Maxim Khutornenko
On Sept. 2, 2014, 7:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 232 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line232 I think this would be clearer inlined. Right now, it's pretty much an alternate name for

Review Request 25204: Adding get job update client APIs.

2014-08-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25204/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-615