Re: Review Request 25753: Surface instance update status changes so they may be persisted.

2014-09-18 Thread Bill Farner
On Sept. 17, 2014, 9:04 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java, line 202 https://reviews.apache.org/r/25753/diff/2/?file=692884#file692884line202 Static import for SideEffect.InstanceUpdateStatus.WORKING? Done for

Re: Review Request 25753: Surface instance update status changes so they may be persisted.

2014-09-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25753/ --- (Updated Sept. 18, 2014, 5:12 p.m.) Review request for Aurora, David

Re: Review Request 25753: Surface instance update status changes so they may be persisted.

2014-09-18 Thread Maxim Khutornenko
On Sept. 17, 2014, 9:04 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java, line 45 https://reviews.apache.org/r/25753/diff/2/?file=692885#file692885line45 Missing xml docs for public methods. Bill Farner wrote: We usually don't

Re: Review Request 25753: Surface instance update status changes so they may be persisted.

2014-09-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25753/#review53753 --- Ship it! Other than the docs, lgtm. - David McLaughlin On Sept.