Re: Review Request 26834: Add client cluster configuration docs.

2014-10-17 Thread Joshua Cohen
> On Oct. 17, 2014, 3:02 p.m., Jay Buffington wrote: > > docs/client-cluster-configuration.md, line 63 > > > > > > I this true? It was my understanding that the only use for this field > > is to format URLs that are

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/ --- (Updated Oct. 17, 2014, 8:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-17 Thread Jay Buffington
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57142 --- docs/client-cluster-configuration.md

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/ --- (Updated Oct. 17, 2014, 12:37 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
> On Oct. 17, 2014, 12:06 a.m., Bill Farner wrote: > > docs/client-cluster-configuration.md, line 14 > > > > > > Mind filing a ticket to collapsing: > > > > zk > > zk_port > > scheduler_zk_path > >

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57072 --- Ship it! docs/client-cluster-configuration.md

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57064 --- Ship it! docs/client-cluster-configuration.md

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
> On Oct. 16, 2014, 11:35 p.m., Bill Farner wrote: > > Please also link to this page from > > https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md > > Bill Farner wrote: > Err...sorry, i thought that was called "deploying-aurora-client.md". The > link wi

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
> On Oct. 16, 2014, 11:35 p.m., Bill Farner wrote: > > Please also link to this page from > > https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md > > Bill Farner wrote: > Err...sorry, i thought that was called "deploying-aurora-client.md". The > link wi

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/ --- (Updated Oct. 16, 2014, 11:58 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Bill Farner
> On Oct. 16, 2014, 11:35 p.m., Bill Farner wrote: > > Please also link to this page from > > https://github.com/apache/incubator-aurora/blob/master/docs/developing-aurora-client.md Err...sorry, i thought that was called "deploying-aurora-client.md". The link will _maybe_ go in the outcome of

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57049 --- Please also link to this page from https://github.com/apache/incuba

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
> On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote: > > docs/client-cluster-configuration.md, line 34 > > > > > > I think an argument could be made for removing this configuration > > entirely and just hardcoding this

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Jay Buffington
> On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote: > > docs/client-cluster-configuration.md, line 34 > > > > > > I think an argument could be made for removing this configuration > > entirely and just hardcoding this

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Kevin Sweeney
> On Oct. 16, 2014, 4:03 p.m., Joshua Cohen wrote: > > docs/client-cluster-configuration.md, line 34 > > > > > > I think an argument could be made for removing this configuration > > entirely and just hardcoding this i

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/#review57030 --- docs/client-cluster-configuration.md

Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-846