---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review70591
---
Master (9233abd) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Feb. 2, 2015, 5:39 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review70587
---
@ReviewBot retry
- Maxim Khutornenko
On Feb. 2, 2015, 5:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review70586
---
Master (9233abd) is red with this patch.
On Jan. 31, 2015, 12:16 a.m., Zameer Manji wrote:
Ship It!
Zameer Manji wrote:
My comment got chompted, I'm expecting these tests to be run on Jenkins
for every commit.
If you check the RB history this has been discussed earlier. The outcome: perf
testing is too machine state
On Jan. 21, 2015, 10:19 a.m., Bill Farner wrote:
Kevin - any chance you're available to take a pass at this soon? My
attempts to free up a chunk of time for a thoughtful review have so far
failed, and this is blocking other work of Maxim's.
I'm afraid my review plate is full for this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Jan. 29, 2015, 8:11 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review70095
---
Ship it!
LGTM. I suspect we will learn more about how this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review68950
---
Kevin - any chance you're available to take a pass at this soon?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69047
---
Meta question - how do you envision us using this? When a perf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69051
---
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
On Jan. 21, 2015, 11:44 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 101
https://reviews.apache.org/r/28731/diff/5/?file=808351#file808351line101
I think we should proceed one of two ways here:
1. whittle this down
On Jan. 21, 2015, 10:27 p.m., Bill Farner wrote:
Meta question - how do you envision us using this? When a perf issue is
discovered, should we generally push for a test case to be added here to
validate the perf fix?
Maxim Khutornenko wrote:
I doubt we can build a
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line
23
https://reviews.apache.org/r/28731/diff/4/?file=792353#file792353line23
Did you consider using `CachedClusterState` instead? That might cause
some
On Jan. 21, 2015, 10:27 p.m., Bill Farner wrote:
Meta question - how do you envision us using this? When a perf issue is
discovered, should we generally push for a test case to be added here to
validate the perf fix?
I doubt we can build a reliable/automated way to catch regressions
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line
23
https://reviews.apache.org/r/28731/diff/4/?file=792353#file792353line23
Did you consider using `CachedClusterState` instead? That might cause
some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Jan. 22, 2015, 1:54 a.m.)
Review request for Aurora, Kevin Sweeney
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line
23
https://reviews.apache.org/r/28731/diff/4/?file=792353#file792353line23
Did you consider using `CachedClusterState` instead? That might cause
some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69116
---
Master (116ee2d) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Jan. 7, 2015, 1:34 a.m.)
Review request for Aurora, Kevin Sweeney and
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/Hosts.java, line 44
https://reviews.apache.org/r/28731/diff/4/?file=792348#file792348line44
It would be nice to supply the minimal attributes we expect - host and
rack designations. this will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review66972
---
Master (1089413) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review66714
---
src/jmh/java/org/apache/aurora/benchmark/Hosts.java
On Dec. 11, 2014, 10:28 p.m., Bill Farner wrote:
Please document new classes (excluding fakes, since they're obvious).
Done.
On Dec. 11, 2014, 10:28 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 96
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review65140
---
Master (52efc93) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Dec. 11, 2014, 8:37 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Dec. 11, 2014, 8:45 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review64792
---
Master (07bc3ab) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review64799
---
Please document new classes (excluding fakes, since they're
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Dec. 5, 2014, 11:02 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review64112
---
This patch does not apply cleanly on master (40d2718), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review63947
---
This patch does not apply cleanly on master (fd37f0d), do you need
33 matches
Mail list logo
