Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-943

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64283 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Maxim Khutornenko
On Dec. 8, 2014, 9:21 p.m., Bill Farner wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 85 https://reviews.apache.org/r/28811/diff/1/?file=785748#file785748line85 Should this be: `self.check_if_drained(drainable_hostnames)` It seems

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64287 --- Ship it! Master (a9e1217) is green with this patch.

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Maxim Khutornenko
On Dec. 8, 2014, 9:21 p.m., Bill Farner wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 85 https://reviews.apache.org/r/28811/diff/1/?file=785748#file785748line85 Should this be: `self.check_if_drained(drainable_hostnames)` It seems

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/ --- (Updated Dec. 8, 2014, 10:43 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 28811: Improving logging experience in admin drain_hosts.

2014-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28811/#review64315 --- Ship it! Master (a9e1217) is green with this patch.