---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69420
---
Master (3fa004b) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69404
---
Master (3fa004b) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69439
---
@ReviewBot retry
- Steve Niemitz
On Jan. 23, 2015, 5:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69447
---
Ship it!
Master (3fa004b) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69480
---
this is looking great. just a few small nits and one higher level
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69505
---
Ship it!
sweet! ship it modulo minor nit below
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69512
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 23, 2015, 4 p.m.,
On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote:
docs/deploying-aurora-scheduler.md, line 163
https://reviews.apache.org/r/28920/diff/18/?file=823201#file823201line163
Philosophical question: if there's already a hard requirement that the
container have Python 2.7 why not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 23, 2015, 4:25 p.m.)
Review request for Aurora, Jay Buffington,
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote:
docs/deploying-aurora-scheduler.md, line 163
https://reviews.apache.org/r/28920/diff/18/?file=823201#file823201line163
Philosophical question: if there's already a hard requirement that the
container have Python 2.7 why not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69282
---
src/main/python/apache/thermos/core/runner.py
On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote:
docs/deploying-aurora-scheduler.md, line 163
https://reviews.apache.org/r/28920/diff/18/?file=823201#file823201line163
Philosophical question: if there's already a hard requirement that the
container have Python 2.7 why not
On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote:
src/main/python/apache/thermos/core/runner.py, lines 627-632
https://reviews.apache.org/r/28920/diff/18/?file=823218#file823218line627
this is an abstraction leak. grep the thermos codebase for 'aurora'
and 'mesos'. thermos
On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote:
src/main/python/apache/thermos/core/runner.py, lines 627-632
https://reviews.apache.org/r/28920/diff/18/?file=823218#file823218line627
this is an abstraction leak. grep the thermos codebase for 'aurora'
and 'mesos'. thermos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69333
---
On Jan. 23, 2015, 2:43 a.m., Jay Buffington wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line
294
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line294
Can you set force_pull_image to true here. I can't imagine why you
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
On Jan. 21, 2015, 6:35 p.m., Kevin Sweeney wrote:
examples/vagrant/provision-dev-cluster.sh, line 17
https://reviews.apache.org/r/28920/diff/18/?file=823204#file823204line17
nit: sh -c indirection is unnecessary here.
Steve Niemitz wrote:
Eh, this is just copied from the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review69288
---
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java,
lines 153-158
https://reviews.apache.org/r/28920/diff/18/?file=823211#file823211line153
can't the stuff in DOCKER_COMMAND_PREFIX be accomplished with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68845
---
Sorry for the delay in reply. I've been thinking a lot about this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68267
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68260
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68247
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 15, 2015, 8:24 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68301
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68350
---
Master (1acb428) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 16, 2015, 12:08 a.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68237
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68232
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68223
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68239
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68241
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68245
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68377
---
Ship it!
Master (b75ed0f) is green with this patch.
On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote:
All nits this round. Last issue for me, as you point out, is
validation/restriction of `ContainerType` in `ConfigurationManager.
Doing a pass on test coverage in the meantime.
Bill Farner wrote:
Test coverage LGTM when
On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote:
All nits this round. Last issue for me, as you point out, is
validation/restriction of `ContainerType` in `ConfigurationManager.
Doing a pass on test coverage in the meantime.
Bill Farner wrote:
Test coverage LGTM when
On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote:
All nits this round. Last issue for me, as you point out, is
validation/restriction of `ContainerType` in `ConfigurationManager.
Doing a pass on test coverage in the meantime.
Bill Farner wrote:
Test coverage LGTM when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68125
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 14, 2015, 8:20 p.m.)
Review request for Aurora, Jay Buffington,
On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote:
All nits this round. Last issue for me, as you point out, is
validation/restriction of `ContainerType` in `ConfigurationManager.
Doing a pass on test coverage in the meantime.
Bill Farner wrote:
Test coverage LGTM when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68112
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68132
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68155
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68185
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68203
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68196
---
Master (a350982) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68210
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68200
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68213
---
Ship it!
Master (a350982) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68219
---
Master (a350982) is red with this patch.
On Jan. 14, 2015, 2:28 a.m., Kevin Sweeney wrote:
examples/jobs/docker/hello_docker.aurora, line 5
https://reviews.apache.org/r/28920/diff/13/?file=818518#file818518line5
since we're supposedly running in the python2.7 container could we show
our version? Bonus points, use a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68062
---
Third time's the charm? I feel like I'm trying to shift without
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68013
---
Partial review, looks good but some questions on the scheduler side
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67985
---
Mostly style and configuration ergonomics remaining. Once these
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 12, 2015, 7:01 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67682
---
Master (a9e0d34) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67702
---
Master (5ce076b) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 12, 2015, 9:40 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67722
---
Master (5ce076b) is red with this patch.
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 13, 2015, 1:11 a.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67781
---
Ship it!
Master (c8154b2) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67761
---
@ReviewBot retry
- Steve Niemitz
On Jan. 12, 2015, 9:40 p.m.,
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 9, 2015, 7:34 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67498
---
Ship it!
Master (74e5471) is green with this patch.
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
On Jan. 8, 2015, 10:48 a.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67226
---
Great patch overall! Mostly documentation and style nits, but also
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 8, 2015, 8:35 p.m.)
Review request for Aurora, Jay Buffington,
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 207
https://reviews.apache.org/r/28920/diff/7/?file=808124#file808124line207
What are the implications of this? Does it mean a docker image must be
pre-loaded on the host
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67289
---
Ship it!
Master (4053924) is green with this patch.
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java, line 109
https://reviews.apache.org/r/28920/diff/7/?file=808132#file808132line109
It's good form for this type of sanitization to happen here, but at
minimum the same
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 207
https://reviews.apache.org/r/28920/diff/7/?file=808124#file808124line207
What are the implications of this? Does it mean a docker image must be
pre-loaded on the host
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66890
---
This patch does not apply cleanly on master (c1174a7), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 6, 2015, 11:32 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66950
---
Ship it!
Master (8c49029) is green with this patch.
On Dec. 13, 2014, 1:59 a.m., Jay Buffington wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line
279
https://reviews.apache.org/r/28920/diff/2/?file=789365#file789365line279
I would do away with this TaskConfig hasProcesses field. You should
just
On Jan. 5, 2015, 8:41 p.m., Joshua Cohen wrote:
This is 99% just style nits. Unfortunately our Java styleguide isn't
published, but I'm working on rectifying that!
Thanks for all the feedback, new patch set coming up!
On Jan. 5, 2015, 8:41 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 5, 2015, 11:53 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 5, 2015, 7:56 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 5, 2015, 8:25 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66692
---
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java
On Jan. 5, 2015, 7:08 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 205
https://reviews.apache.org/r/28920/diff/4/?file=801608#file801608line205
This can't be made private due to the way @Timed works (for more
information see
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66702
---
This is 99% just style nits. Unfortunately our Java styleguide
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Dec. 26, 2014, 9:05 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review66172
---
Ship it!
Master (c331bcd) is green with this patch.
On Dec. 13, 2014, 1:59 a.m., Jay Buffington wrote:
I haven't had time to complete this review, but I wanted to give you what I
have so far. This is all fantastic and I really appreciate you doing this!
I'm excited to start using this implementation.
You should update
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Dec. 16, 2014, 9:19 p.m.)
Review request for Aurora, Jay Buffington,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review65249
---
There some issues here with usability that maybe this patch doesn't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review65276
---
Sorry for the multiple reviews. There is a lot here. Maybe we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review65000
---
I haven't had time to complete this review, but I wanted to give
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review64735
---
Ship it!
Master (5d8d3e1) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
Review request for Aurora.
Summary (updated)
-
Add support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review64657
---
Ship it!
Master (2aac148) is green with this patch.
1 - 100 of 101 matches
Mail list logo
