Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/#review71505 --- Ship it! These are all nits, looks good to me.

Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-08 Thread Brian Wickman
On Feb. 6, 2015, 9:44 p.m., Joshua Cohen wrote: src/main/python/apache/thermos/monitoring/detector.py, line 45 https://reviews.apache.org/r/30741/diff/2/?file=852426#file852426line45 Just for my own education, what's the difference between returning `self._paths` and

Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/#review71518 --- Ship it! Master (da296a3) is green with this patch.

Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-08 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/ --- (Updated Feb. 6, 2015, 10:40 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1024

Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/#review71486 --- Ship it! Master (da296a3) is green with this patch.

Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/ --- (Updated Feb. 6, 2015, 7:30 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 30741: Add an interface and implementations of PathDetector.

2015-02-06 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/#review71487 --- Ship it! Ship It! - Zameer Manji On Feb. 6, 2015, 11:30 a.m.,