---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/#review73342
---
Ship it!
On Feb. 19, 2015, 1:11 p.m., Zameer Manji wrote:
Ship it, modulo my concern over uncessarily creating an IJobUpdateKey from
PruneVictim.
Bill clarified the creating IJobUpdateKey from PruneVictim offline. PruneVictim
needs to have the mutable types so it can be populated from storage.
On Feb. 20, 2015, 11:36 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/Updates.java, line 43
https://reviews.apache.org/r/31170/diff/2/?file=869688#file869688line43
JobKeys.assertValid(summary.getJobKey()) should be better here.
Also,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/
---
(Updated Feb. 21, 2015, 1:43 a.m.)
Review request for Aurora, Maxim
On Feb. 18, 2015, 5:17 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java,
line 166
https://reviews.apache.org/r/31170/diff/1/?file=868472#file868472line166
Shouldn't PruneVictim have the IJobUpdateKey as the parameter?
Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/#review73199
---
Ship it!
Ship it, modulo my concern over uncessarily creating an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/#review73038
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170/#review73042
---
Ship it!
Master (e0e3f2e) is green with this patch.
