Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31241/#review73328 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31241/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31241/#review73373 --- This patch does not apply cleanly on master (e5de618), do you need

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31241/#review73368 --- Ship it! Ship It! - Bill Farner On Feb. 21, 2015, 12:15 a.m.,

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31241/ --- (Updated Feb. 21, 2015, 12:15 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 31241: Pushing transactions up in QuotaManager.

2015-02-20 Thread Maxim Khutornenko
On Feb. 20, 2015, 10:37 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 77 https://reviews.apache.org/r/31241/diff/1/?file=871169#file871169line77 Would `QuotaStore.Mutable` be sufficient? That would align with LoD. Done, Though we