date:20140423

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review41145
---



src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js


For completeness, please add SANDBOX_DELETED as: "The task sandbox has been 
deleted by the executor."


- Maxim Khutornenko


On April 23, 2014, 1:39 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> ---
> 
> (Updated April 23, 2014, 1:39 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
> https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> 3db34ecf9a977fe4c84d1d00990d90248b40316e 
> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> ---
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was 
> messed up. I'm not sure how to force a task with the Vagrant file into 
> DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/
---

(Updated April 23, 2014, 3:02 p.m.)


Review request for Aurora, Suman Karumuri and Maxim Khutornenko.


Changes
---

Added SANDBOX_DELETED.


Bugs: AURORA-265
https://issues.apache.org/jira/browse/AURORA-265


Repository: aurora


Description
---

AURORA-265: Add missing tooltips for task states in dictionary.js


Diffs (updated)
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
3db34ecf9a977fe4c84d1d00990d90248b40316e 

Diff: https://reviews.apache.org/r/20146/diff/


Testing
---

Visually inspected the scheduler w/ a sample job to verify that nothing was 
messed up. I'm not sure how to force a task with the Vagrant file into DRAINING 
or THROTTLED states.


Thanks,

Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/
---

(Updated April 23, 2014, 3:02 p.m.)


Review request for Aurora, Suman Karumuri and Maxim Khutornenko.


Changes
---

Added SANDBOX_DELETED.


Bugs: AURORA-265
https://issues.apache.org/jira/browse/AURORA-265


Repository: aurora


Description
---

AURORA-265: Add missing tooltips for task states in dictionary.js


Diffs
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
3db34ecf9a977fe4c84d1d00990d90248b40316e 

Diff: https://reviews.apache.org/r/20146/diff/


Testing
---

Visually inspected the scheduler w/ a sample job to verify that nothing was 
messed up. I'm not sure how to force a task with the Vagrant file into DRAINING 
or THROTTLED states.


Thanks,

Dan Norris

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review41146
---

Ship it!



src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js


Missing "," for the new records.


- Maxim Khutornenko


On April 23, 2014, 3:02 p.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> ---
> 
> (Updated April 23, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
> https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> 3db34ecf9a977fe4c84d1d00990d90248b40316e 
> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> ---
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was 
> messed up. I'm not sure how to force a task with the Vagrant file into 
> DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris



> On April 23, 2014, 3:14 p.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line 
> > 22
> > 
> >
> > Missing "," for the new records.

That's what I get for multitasking Fix should be up shortly.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/#review41146
---


On April 23, 2014, 3:02 p.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20146/
> ---
> 
> (Updated April 23, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-265
> https://issues.apache.org/jira/browse/AURORA-265
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-265: Add missing tooltips for task states in dictionary.js
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
> 3db34ecf9a977fe4c84d1d00990d90248b40316e 
> 
> Diff: https://reviews.apache.org/r/20146/diff/
> 
> 
> Testing
> ---
> 
> Visually inspected the scheduler w/ a sample job to verify that nothing was 
> messed up. I'm not sure how to force a task with the Vagrant file into 
> DRAINING or THROTTLED states.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20490: Add a "get version" API method.

2014-04-23 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review41149
---

Ship it!


Ship It!

- Brian Wickman


On April 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
> ---
> 
> (Updated April 22, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
> 
> While I'm in there, fix a bug in "job list".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0793a1ae4bd5d641ea57473705076290d77ac2b6 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 
> 
> Diff: https://reviews.apache.org/r/20490/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> = 27 passed in 0.64 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> colle

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko



> On April 22, 2014, 7:57 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java, line 65
> > 
> >
> > I'm still failing to see the upside of this enum.  An obvious downside 
> > is that MetricCalculator.METRICS must be manually kept in sync with this, 
> > but a 1:1 mapping is expected.  Why not push the whole thing up there?

This enum keeps all algorithm details private to the interface exposing only 
the configurations that intended to be consumed. It better aligns test with 
prod as tests can't create algorithms with parameters other than what's visible 
to MetricCalculator. The approach is consistent with the SlaGroup.GroupType and 
will help isolating future algorithm development/reuse from the consumption. It 
also helps readability on the declaration side (METRICS). 


> On April 22, 2014, 7:57 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 
> > 179
> > 
> >
> > Can you avoid the extra flag and loop if you just let Counter keep 
> > track of it?
> > 
> >   class Counter {
> > Counter(..) {
> >   // Object is initialized, but value not yet valid
> > }
> > 
> > private void set(..) {
> >   // Value provided is guaranteed to be up to date
> >   if (!exported) {
> > statsProvider.makeGauge(name, this);
> > exported = true;
> >   }
> >   ...
> > }
> >   }
> > 
> > I would find this easier to follow.

Good idea. Done.


> On April 22, 2014, 7:57 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java, line 40
> > 
> >
> > list.isEmpty()

Done.


> On April 22, 2014, 7:57 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java, line 55
> > 
> >
> > funky indent

Fixed.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20398/#review41053
---


On April 18, 2014, 8:43 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20398/
> ---
> 
> (Updated April 18, 2014, 8:43 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-293
> https://issues.apache.org/jira/browse/AURORA-293
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> High level overview:
> - MetricCalculator runs periodically (every minute), pulls all task history, 
> packages it into SlaInstance list and updates stats;
> - Stat calculation is handled by a pair of: SlaAlgorithm and a set of 
> applicable SlaGroups (logical groupings by job, cluster, resource and etc.);
> - Stat name is generated by combining group and algorithm name parts.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> eeafc784e915137cacd5f64df1252ccbaf6c0f6c 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> bc77bf2e6fbc1ff4159d049b0c28afd6832499ef 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> fae2d237d18f945d4dd73ec56cd42981359bea46 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 56f47b6545ed618b5ed754badfdbcaebdf6fc222 
>   src/main/java/org/apache/aurora/scheduler/quota/ResourceAggregates.java 
> 444c2872ae8fcf1683e9eea6f38cd42877641366 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> b6610f76f2ac665f258ecd05df367cfd54b97d58 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 14af68f4c53019f0d5d9947e0eece15e4375176a 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
> 415b48cee907f9d325fb25e03a290eda1b8cc09b

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20398/
---

(Updated April 23, 2014, 5:42 p.m.)


Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-293
https://issues.apache.org/jira/browse/AURORA-293


Repository: aurora


Description
---

High level overview:
- MetricCalculator runs periodically (every minute), pulls all task history, 
packages it into SlaInstance list and updates stats;
- Stat calculation is handled by a pair of: SlaAlgorithm and a set of 
applicable SlaGroups (logical groupings by job, cluster, resource and etc.);
- Stat name is generated by combining group and algorithm name parts.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
2bedf9bbbccf4c43760cd68b5825c44f279a63ca 
  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
bc77bf2e6fbc1ff4159d049b0c28afd6832499ef 
  src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
fae2d237d18f945d4dd73ec56cd42981359bea46 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
56f47b6545ed618b5ed754badfdbcaebdf6fc222 
  src/main/java/org/apache/aurora/scheduler/quota/ResourceAggregates.java 
444c2872ae8fcf1683e9eea6f38cd42877641366 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
b6610f76f2ac665f258ecd05df367cfd54b97d58 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
14af68f4c53019f0d5d9947e0eece15e4375176a 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
415b48cee907f9d325fb25e03a290eda1b8cc09b 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 4a13dbc5485b4563af93548ebc50b01de2303968 

Diff: https://reviews.apache.org/r/20398/diff/


Testing
---

gradle build
gradle run

Sample from local scheduler:

sla_cluster_mtta 3271.493
sla_cluster_mttr 3273.497
sla_cluster_platform_uptime_percent 100.0
sla_cpu_small_mtta 3271.493
sla_cpu_small_mttr 3273.497
sla_disk_small_mtta 3271.493
sla_disk_small_mttr 3273.497
sla_mesos_test_serviceJob0_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob0_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob0_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob0_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob0_mtta 0.0
sla_mesos_test_serviceJob0_mttr 0.0
sla_mesos_test_serviceJob0_platform_uptime_percent 100.0
sla_mesos_test_serviceJob10_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob10_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob10_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob10_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob10_mtta 0.0
sla_mesos_test_serviceJob10_mttr 0.0
sla_mesos_test_serviceJob10_platform_uptime_percent 100.0
sla_mesos_test_serviceJob12_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob12_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob12_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob12_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob12_mtta 0.0
sla_mesos_test_serviceJob12_mttr 0.0
sla_mesos_test_serviceJob12_platform_uptime_percent 100.0
sla_mesos_test_serviceJob14_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob14_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob14_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob14_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob14_mtta 0.0
sla_mesos_test_serviceJob14_mttr 0.0
sla_mesos_test_serviceJob14_platform_uptime_percent 100.0
sla_mesos_test_serviceJob16_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob16_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob16_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob16_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob16_mtta 0.0
sla_mesos_test_serviceJob16_mttr 0.0
sla_mesos_test_serviceJob16_platform_uptime_percent 100.0
sla_mesos_test_serviceJob18_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob18_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob18_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob18_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob18_mtta 0.0
sla_mesos_test_serviceJob18_mttr 0.0
sla_mesos_test_serviceJob18_platform_uptime_percent 100.0
sla_mesos_test_serviceJob2_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob2_job_uptime_90_00_sec 0
sla_mes

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20573/#review41172
---

Ship it!



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java


Your call, but you could extract a convenience function (this is basically 
part of the body from the previous behavior):

  private static Query.Builder maybeRoleScoped(Optional role) {
return role.isPresent() ? Query.roleScoped(role.get()) : 
Query.unscoped();
  }

Then the work here becomes:

  getTasks(maybeRoleScoped(ownerRole))

and in the method below:

  getTasks(maybeRoleScoped(ownerRole).active())



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java


s/Builder/Query.Builder/, matching uses elsewhere in this file.


- Bill Farner


On April 23, 2014, 6:55 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20573/
> ---
> 
> (Updated April 23, 2014, 6:55 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-338
> https://issues.apache.org/jira/browse/AURORA-338
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently, the getTasks query was only fetching tasks in active status. 
> Updated the code to fetching all tasks for getJobSummary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  84151a5308c12b3bee7cf5fd662776e574e8fadf 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  f530c530548444c57d9aeb5ed100a5fda5bd2953 
> 
> Diff: https://reviews.apache.org/r/20573/diff/
> 
> 
> Testing
> ---
> 
> Tested on laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19767/#review41178
---

Ship it!


Latest changes LGTM!

- Bill Farner


On April 22, 2014, 1:04 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19767/
> ---
> 
> (Updated April 22, 2014, 1:04 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-132
> https://issues.apache.org/jira/browse/AURORA-132
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This introduces a new CronScheduler based on Quartz and removes the 
> NoopCronScheduler.
> 
> 
> Diffs
> -
> 
>   build.gradle 3c0c63710dfb177dc2df1d504cbc00d75bce67c6 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 86bbc29c64dd62037ad6bc51b8daa30115eaf74c 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> ec56c649116c03ef148bac916bd6691a94685bc3 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> 6aff091d9afefc73af666f980ef96acd726aec20 
>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
> db1bec4f508c8908f212aa541fb86e041a8c471c 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  82034e008e5dbaa3124dc154cdc6c5e9767ca87f 
>   src/main/java/org/apache/aurora/scheduler/cron/CronJobManager.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 
> df0c37839c5da54795404c18ff9fc93084cd32e4 
>   src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 
> 56e9950fd94ae1e3dbd96baec00b7e6b262fbe34 
>   src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java 
> 2bb848a7f5f096b1c85596e4130f0656e9a4401e 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronModule.java 
> e0935f5eab8a101f4ce1831f260f9a23137124ce 
>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 
> 7b25152c0258e10be21b801cae1444c518367fa7 
>   src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java 
> a31551c77818c17ee0f9f71b5ab458a3b853dc6a 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 
> 61b01d2575d6cfce069e77c39bfa8f8680cf4298 
>   src/main/java/org/apache/aurora/scheduler/http/Cron.java 
> 80a398a5f297558a25c0a0c63afcb049a9558e44 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
> f0469c157fee79c4fd2b842db7a4a37fd3d7e83e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> efea75f3d5a5f4c538c63cc15d5a004d891c2a4a 
>   src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 
> 4bd190cd608c167f31f06fba6185ce825926e37e 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> 5696485e5beb9b7bf4ccee8b6189f25db51aff39 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
> 7d26082b74f62f35865e0343f9ba8b475e075d62 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  84151a5308c12b3bee7cf5fd662776e574e8fadf 
>   
> src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
>   
>   src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/Cron

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19767/
---

(Updated April 23, 2014, 11:39 a.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Rebase to pick up UI removal


Bugs: AURORA-132
https://issues.apache.org/jira/browse/AURORA-132


Repository: aurora


Description
---

This introduces a new CronScheduler based on Quartz and removes the 
NoopCronScheduler.


Diffs (updated)
-

  build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
86bbc29c64dd62037ad6bc51b8daa30115eaf74c 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
6aff091d9afefc73af666f980ef96acd726aec20 
  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
db1bec4f508c8908f212aa541fb86e041a8c471c 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 82034e008e5dbaa3124dc154cdc6c5e9767ca87f 
  src/main/java/org/apache/aurora/scheduler/cron/CronJobManager.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 
df0c37839c5da54795404c18ff9fc93084cd32e4 
  src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 
56e9950fd94ae1e3dbd96baec00b7e6b262fbe34 
  src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java 
2bb848a7f5f096b1c85596e4130f0656e9a4401e 
  src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronModule.java 
e0935f5eab8a101f4ce1831f260f9a23137124ce 
  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 
7b25152c0258e10be21b801cae1444c518367fa7 
  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java 
a31551c77818c17ee0f9f71b5ab458a3b853dc6a 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 
61b01d2575d6cfce069e77c39bfa8f8680cf4298 
  src/main/java/org/apache/aurora/scheduler/http/Cron.java 
80a398a5f297558a25c0a0c63afcb049a9558e44 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
983101277ffbd1c4017b29f4c86e61315f1bcc78 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
efea75f3d5a5f4c538c63cc15d5a004d891c2a4a 
  src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 
4bd190cd608c167f31f06fba6185ce825926e37e 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
5696485e5beb9b7bf4ccee8b6189f25db51aff39 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
536927949c915363cccf074449d089314ecf6996 
  src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
7d26082b74f62f35865e0343f9ba8b475e075d62 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
84151a5308c12b3bee7cf5fd662776e574e8fadf 
  
src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
  
  src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
a9b85d0983dcfee89101a5e774ba86ee11708c68 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
d7dbfaa76b277b028e56ed633ea2a032935e26db 
  src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 
fa9cb757936542c483699b3fc6bba944d717abac 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
c8ad55d8d48f7e96180846ab515dd4df3d8ed79e 
  
src/test/java/org/apache/aurora/scheduler/th

Review Request 20620: Add machine maintainer auth capability.

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20620/
---

Review request for Aurora, Suman Karumuri and Maxim Khutornenko.


Bugs: AURORA-348
https://issues.apache.org/jira/browse/AURORA-348


Repository: aurora


Description
---

Add machine maintainer auth capability.


Diffs
-

  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
a2e215eeebd3f8fc2a5a62b6c6f6dc1c92611a3a 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
84151a5308c12b3bee7cf5fd662776e574e8fadf 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 f530c530548444c57d9aeb5ed100a5fda5bd2953 

Diff: https://reviews.apache.org/r/20620/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Review Request 20629: End to end test should not look at the number of html lines.

2014-04-23 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20629/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

End to end test should not look at the number of html lines.


Diffs
-

  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
f0f2ab53c1f484a480eb2ea8766c5d299e3b8c99 

Diff: https://reviews.apache.org/r/20629/diff/


Testing
---

end-to-end test


Thanks,

Brian Wickman

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20398/#review41201
---

Ship it!



src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java


You can save a good amount of wiring boilerplate if you use Guava's 
AbstractScheduledService [1] here instead. Perhaps drop a TODO?

[1] 
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/AbstractScheduledService.html



src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java


logical grouping of what?



src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java


again, this could be simplified with AbstractScheduledService


- Kevin Sweeney


On April 23, 2014, 10:42 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20398/
> ---
> 
> (Updated April 23, 2014, 10:42 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-293
> https://issues.apache.org/jira/browse/AURORA-293
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> High level overview:
> - MetricCalculator runs periodically (every minute), pulls all task history, 
> packages it into SlaInstance list and updates stats;
> - Stat calculation is handled by a pair of: SlaAlgorithm and a set of 
> applicable SlaGroups (logical groupings by job, cluster, resource and etc.);
> - Stat name is generated by combining group and algorithm name parts.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 2bedf9bbbccf4c43760cd68b5825c44f279a63ca 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> bc77bf2e6fbc1ff4159d049b0c28afd6832499ef 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> fae2d237d18f945d4dd73ec56cd42981359bea46 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 56f47b6545ed618b5ed754badfdbcaebdf6fc222 
>   src/main/java/org/apache/aurora/scheduler/quota/ResourceAggregates.java 
> 444c2872ae8fcf1683e9eea6f38cd42877641366 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> b6610f76f2ac665f258ecd05df367cfd54b97d58 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 14af68f4c53019f0d5d9947e0eece15e4375176a 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
> 415b48cee907f9d325fb25e03a290eda1b8cc09b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  4a13dbc5485b4563af93548ebc50b01de2303968 
> 
> Diff: https://reviews.apache.org/r/20398/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> gradle run
> 
> Sample from local scheduler:
> 
> sla_cluster_mtta 3271.493
> sla_cluster_mttr 3273.497
> sla_cluster_platform_uptime_percent 100.0
> sla_cpu_small_mtta 3271.493
> sla_cpu_small_mttr 3273.497
> sla_disk_small_mtta 3271.493
> sla_disk_small_mttr 3273.497
> sla_mesos_test_serviceJob0_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob0_mtta 0.0
> sla_mesos_test_serviceJob0_mttr 0.0
> sla_mesos_test_serviceJob0_platform_uptime_percent 100.0
> sla_mesos_test_serviceJob10_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob10_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob10_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob10_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob10_mtta 0.0
> sla_mesos_test_serviceJob10_mttr 0.0
> sla_mesos_test_serviceJob10_platform_uptime_percent 100.0
> sla_mesos_test_serviceJob12_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob12_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob12_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob12_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob12_mtta 0.0
> sla_mesos

Re: Review Request 20629: End to end test should not look at the number of html lines.

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20629/#review41238
---

Ship it!


Ship It!

- Kevin Sweeney


On April 23, 2014, 12:59 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20629/
> ---
> 
> (Updated April 23, 2014, 12:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> End to end test should not look at the number of html lines.
> 
> 
> Diffs
> -
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> f0f2ab53c1f484a480eb2ea8766c5d299e3b8c99 
> 
> Diff: https://reviews.apache.org/r/20629/diff/
> 
> 
> Testing
> ---
> 
> end-to-end test
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20573/
---

(Updated April 23, 2014, 11:08 p.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-338
https://issues.apache.org/jira/browse/AURORA-338


Repository: aurora


Description
---

Currently, the getTasks query was only fetching tasks in active status. Updated 
the code to fetching all tasks for getJobSummary.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
84151a5308c12b3bee7cf5fd662776e574e8fadf 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 f530c530548444c57d9aeb5ed100a5fda5bd2953 

Diff: https://reviews.apache.org/r/20573/diff/


Testing
---

Tested on laptop.


Thanks,

Suman Karumuri

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Suman Karumuri



> On April 23, 2014, 6:15 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 407
> > 
> >
> > Your call, but you could extract a convenience function (this is 
> > basically part of the body from the previous behavior):
> > 
> >   private static Query.Builder maybeRoleScoped(Optional role) {
> > return role.isPresent() ? Query.roleScoped(role.get()) : 
> > Query.unscoped();
> >   }
> > 
> > Then the work here becomes:
> > 
> >   getTasks(maybeRoleScoped(ownerRole))
> > 
> > and in the method below:
> > 
> >   getTasks(maybeRoleScoped(ownerRole).active())

Changed.


> On April 23, 2014, 6:15 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 476
> > 
> >
> > s/Builder/Query.Builder/, matching uses elsewhere in this file.

Changed.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20573/#review41172
---


On April 23, 2014, 11:08 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20573/
> ---
> 
> (Updated April 23, 2014, 11:08 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-338
> https://issues.apache.org/jira/browse/AURORA-338
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Currently, the getTasks query was only fetching tasks in active status. 
> Updated the code to fetching all tasks for getJobSummary.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  84151a5308c12b3bee7cf5fd662776e574e8fadf 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  f530c530548444c57d9aeb5ed100a5fda5bd2953 
> 
> Diff: https://reviews.apache.org/r/20573/diff/
> 
> 
> Testing
> ---
> 
> Tested on laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko



> On April 23, 2014, 10:16 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 67
> > 
> >
> > You can save a good amount of wiring boilerplate if you use Guava's 
> > AbstractScheduledService [1] here instead. Perhaps drop a TODO?
> > 
> > [1] 
> > http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/AbstractScheduledService.html

The AbstractScheduledService is good for maintaining a stateful service, which 
MetricCalculator is not. I.e. there is nothing to do in start() or stop() right 
now. I gave it a try anyway to see if it at least handles errors properly but 
no, I still had to use afterExecute() hack to surface any unhandled exceptions. 


> On April 23, 2014, 10:16 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java, line 42
> > 
> >
> > logical grouping of what?

Clarified.


> On April 23, 2014, 10:16 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java, line 68
> > 
> >
> > again, this could be simplified with AbstractScheduledService

Unfortunately, it does not.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20398/#review41201
---


On April 23, 2014, 5:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20398/
> ---
> 
> (Updated April 23, 2014, 5:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-293
> https://issues.apache.org/jira/browse/AURORA-293
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> High level overview:
> - MetricCalculator runs periodically (every minute), pulls all task history, 
> packages it into SlaInstance list and updates stats;
> - Stat calculation is handled by a pair of: SlaAlgorithm and a set of 
> applicable SlaGroups (logical groupings by job, cluster, resource and etc.);
> - Stat name is generated by combining group and algorithm name parts.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 2bedf9bbbccf4c43760cd68b5825c44f279a63ca 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> bc77bf2e6fbc1ff4159d049b0c28afd6832499ef 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> fae2d237d18f945d4dd73ec56cd42981359bea46 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 56f47b6545ed618b5ed754badfdbcaebdf6fc222 
>   src/main/java/org/apache/aurora/scheduler/quota/ResourceAggregates.java 
> 444c2872ae8fcf1683e9eea6f38cd42877641366 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> b6610f76f2ac665f258ecd05df367cfd54b97d58 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 14af68f4c53019f0d5d9947e0eece15e4375176a 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
> 415b48cee907f9d325fb25e03a290eda1b8cc09b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  4a13dbc5485b4563af93548ebc50b01de2303968 
> 
> Diff: https://reviews.apache.org/r/20398/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> gradle run
> 
> Sample from local scheduler:
> 
> sla_cluster_mtta 3271.493
> sla_cluster_mttr 3273.497
> sla_cluster_platform_uptime_percent 100.0
> sla_cpu_small_mtta 3271.493
> sla_cpu_small_mttr 3273.497
> sla_disk_small_mtta 3271.493
> sla_disk_small_mttr 3273.497
> sla_mesos_test_serviceJob0_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob0_mtta 0.0
> sla_mesos_test_serviceJob0_mttr 0.0
> sla_mesos

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20398/#review41244
---


you can pull me off the review on this one.

- Brian Wickman


On April 23, 2014, 5:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20398/
> ---
> 
> (Updated April 23, 2014, 5:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-293
> https://issues.apache.org/jira/browse/AURORA-293
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> High level overview:
> - MetricCalculator runs periodically (every minute), pulls all task history, 
> packages it into SlaInstance list and updates stats;
> - Stat calculation is handled by a pair of: SlaAlgorithm and a set of 
> applicable SlaGroups (logical groupings by job, cluster, resource and etc.);
> - Stat name is generated by combining group and algorithm name parts.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 2bedf9bbbccf4c43760cd68b5825c44f279a63ca 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> bc77bf2e6fbc1ff4159d049b0c28afd6832499ef 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> fae2d237d18f945d4dd73ec56cd42981359bea46 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 56f47b6545ed618b5ed754badfdbcaebdf6fc222 
>   src/main/java/org/apache/aurora/scheduler/quota/ResourceAggregates.java 
> 444c2872ae8fcf1683e9eea6f38cd42877641366 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
> b6610f76f2ac665f258ecd05df367cfd54b97d58 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 14af68f4c53019f0d5d9947e0eece15e4375176a 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
> 415b48cee907f9d325fb25e03a290eda1b8cc09b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  4a13dbc5485b4563af93548ebc50b01de2303968 
> 
> Diff: https://reviews.apache.org/r/20398/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> gradle run
> 
> Sample from local scheduler:
> 
> sla_cluster_mtta 3271.493
> sla_cluster_mttr 3273.497
> sla_cluster_platform_uptime_percent 100.0
> sla_cpu_small_mtta 3271.493
> sla_cpu_small_mttr 3273.497
> sla_disk_small_mtta 3271.493
> sla_disk_small_mttr 3273.497
> sla_mesos_test_serviceJob0_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob0_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob0_mtta 0.0
> sla_mesos_test_serviceJob0_mttr 0.0
> sla_mesos_test_serviceJob0_platform_uptime_percent 100.0
> sla_mesos_test_serviceJob10_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob10_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob10_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob10_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob10_mtta 0.0
> sla_mesos_test_serviceJob10_mttr 0.0
> sla_mesos_test_serviceJob10_platform_uptime_percent 100.0
> sla_mesos_test_serviceJob12_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob12_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob12_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob12_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob12_mtta 0.0
> sla_mesos_test_serviceJob12_mttr 0.0
> sla_mesos_test_serviceJob12_platform_uptime_percent 100.0
> sla_mesos_test_serviceJob14_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob14_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob14_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob14_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob14_mtta 0.0
> sla_mesos_test_serviceJob14_mttr 0.0
> sla_mesos_test_serviceJob14_platform_uptime_percent 100.0
> sla_mesos_test_serviceJob16_job_uptime_75_00_sec 0
> sla_mesos_test_serviceJob16_job_uptime_90_00_sec 0
> sla_mesos_test_serviceJob16_job_uptime_95_00_sec 0
> sla_mesos_test_serviceJob16_job_uptime_99_00_sec 0
> sla_mesos_test_serviceJob16_mtta 0.

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20398/
---

(Updated April 23, 2014, 11:52 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebasing and dropping wickman from the list.


Bugs: AURORA-293
https://issues.apache.org/jira/browse/AURORA-293


Repository: aurora


Description
---

High level overview:
- MetricCalculator runs periodically (every minute), pulls all task history, 
packages it into SlaInstance list and updates stats;
- Stat calculation is handled by a pair of: SlaAlgorithm and a set of 
applicable SlaGroups (logical groupings by job, cluster, resource and etc.);
- Stat name is generated by combining group and algorithm name parts.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
2bedf9bbbccf4c43760cd68b5825c44f279a63ca 
  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
bc77bf2e6fbc1ff4159d049b0c28afd6832499ef 
  src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
fae2d237d18f945d4dd73ec56cd42981359bea46 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
56f47b6545ed618b5ed754badfdbcaebdf6fc222 
  src/main/java/org/apache/aurora/scheduler/quota/ResourceAggregates.java 
444c2872ae8fcf1683e9eea6f38cd42877641366 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
b6610f76f2ac665f258ecd05df367cfd54b97d58 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
14af68f4c53019f0d5d9947e0eece15e4375176a 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
415b48cee907f9d325fb25e03a290eda1b8cc09b 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 4a13dbc5485b4563af93548ebc50b01de2303968 

Diff: https://reviews.apache.org/r/20398/diff/


Testing
---

gradle build
gradle run

Sample from local scheduler:

sla_cluster_mtta 3271.493
sla_cluster_mttr 3273.497
sla_cluster_platform_uptime_percent 100.0
sla_cpu_small_mtta 3271.493
sla_cpu_small_mttr 3273.497
sla_disk_small_mtta 3271.493
sla_disk_small_mttr 3273.497
sla_mesos_test_serviceJob0_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob0_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob0_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob0_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob0_mtta 0.0
sla_mesos_test_serviceJob0_mttr 0.0
sla_mesos_test_serviceJob0_platform_uptime_percent 100.0
sla_mesos_test_serviceJob10_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob10_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob10_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob10_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob10_mtta 0.0
sla_mesos_test_serviceJob10_mttr 0.0
sla_mesos_test_serviceJob10_platform_uptime_percent 100.0
sla_mesos_test_serviceJob12_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob12_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob12_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob12_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob12_mtta 0.0
sla_mesos_test_serviceJob12_mttr 0.0
sla_mesos_test_serviceJob12_platform_uptime_percent 100.0
sla_mesos_test_serviceJob14_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob14_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob14_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob14_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob14_mtta 0.0
sla_mesos_test_serviceJob14_mttr 0.0
sla_mesos_test_serviceJob14_platform_uptime_percent 100.0
sla_mesos_test_serviceJob16_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob16_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob16_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob16_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob16_mtta 0.0
sla_mesos_test_serviceJob16_mttr 0.0
sla_mesos_test_serviceJob16_platform_uptime_percent 100.0
sla_mesos_test_serviceJob18_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob18_job_uptime_90_00_sec 0
sla_mesos_test_serviceJob18_job_uptime_95_00_sec 0
sla_mesos_test_serviceJob18_job_uptime_99_00_sec 0
sla_mesos_test_serviceJob18_mtta 0.0
sla_mesos_test_serviceJob18_mttr 0.0
sla_mesos_test_serviceJob18_platform_uptime_percent 100.0
sla_mesos_test_serviceJob2_job_uptime_75_00_sec 0
sla_mesos_test_serviceJob2_job_uptime_90

Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/
---

Review request for Aurora, Bill Farner and Brian Wickman.


Bugs: AURORA-349
https://issues.apache.org/jira/browse/AURORA-349


Repository: aurora


Description
---

Fix createJob to accept non-cron jobs.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
09b7fbd5832991226bc5a012a0a1f5249ac825e6 

Diff: https://reviews.apache.org/r/20640/diff/


Testing
---

./gradlew build

Awaiting e2e run.


Thanks,

Kevin Sweeney

Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Dave Lester


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Repository: aurora


Description
---

Renames documentation filenames in associated links to be SEO friendly, per 
AURORA-48.


Diffs
-

  docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
  docs/clientcommands.md  
  docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
  docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
  docs/resourceisolation.md  
  docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
  docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 

Diff: https://reviews.apache.org/r/20641/diff/


Testing
---

Checked that relative links within the markdown documents were updated to 
reflect new filenames.


Thanks,

Dave Lester

Re: Review Request 19627: Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent.

2014-04-23 Thread Dave Lester



> On April 21, 2014, 6:57 p.m., Bill Farner wrote:
> > Dave - is this review still relevant?

Thanks for following-up! Yes, it is.


- Dave


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19627/#review40920
---


On March 25, 2014, 8:54 p.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19627/
> ---
> 
> (Updated March 25, 2014, 8:54 p.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updates documentation to add headers to pages that needed them, cleans up 
> whitespace, and makes markdown for headers consistent.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec 
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 
>   docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
>   docs/developing-aurora-scheduler.md 
> 95bf47278b4cf040ed902e43a151fe9fae19bfc5 
>   docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 
>   docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
>   docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
>   docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 
> 
> Diff: https://reviews.apache.org/r/19627/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 19627: Updates documentation files for markdown consistency

2014-04-23 Thread Dave Lester


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19627/
---

(Updated April 24, 2014, 12:43 a.m.)


Review request for Aurora and Mark Chu-Carroll.


Summary (updated)
-

Updates documentation files for markdown consistency


Repository: aurora


Description
---

Updates documentation to add headers to pages that needed them, cleans up 
whitespace, and makes markdown for headers consistent.


Diffs
-

  docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
  docs/clientcommands.md adf378c49d4e6a6fbc399976c034a7af390437ec 
  docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
  docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
  docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 
  docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
  docs/developing-aurora-scheduler.md 95bf47278b4cf040ed902e43a151fe9fae19bfc5 
  docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 
  docs/resourceisolation.md 7e8d88d09093d85c07c84bd3d6476fc89ff21c3b 
  docs/tutorial.md 3ccc862e7819af89d414d10325c90e10a6e49887 
  docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
  docs/vagrant.md 15d72bc57e2d26222ce7b664ece887c06b2c0e53 

Diff: https://reviews.apache.org/r/19627/diff/


Testing
---


Thanks,

Dave Lester

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/#review41252
---

Ship it!


Ship It!

- Kevin Sweeney


On April 23, 2014, 5:40 p.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20641/
> ---
> 
> (Updated April 23, 2014, 5:40 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Renames documentation filenames in associated links to be SEO friendly, per 
> AURORA-48.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md  
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/resourceisolation.md  
>   docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
> 
> Diff: https://reviews.apache.org/r/20641/diff/
> 
> 
> Testing
> ---
> 
> Checked that relative links within the markdown documents were updated to 
> reflect new filenames.
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/
---

(Updated April 23, 2014, 6:06 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Bugs: AURORA-349
https://issues.apache.org/jira/browse/AURORA-349


Repository: aurora


Description
---

Fix createJob to accept non-cron jobs.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
09b7fbd5832991226bc5a012a0a1f5249ac825e6 

Diff: https://reviews.apache.org/r/20640/diff/


Testing (updated)
---

./gradlew build

Awaiting e2e test


Thanks,

Kevin Sweeney

Re: Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/
---

(Updated April 23, 2014, 6:10 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Bugs: AURORA-349
https://issues.apache.org/jira/browse/AURORA-349


Repository: aurora


Description
---

Fix createJob to accept non-cron jobs.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
09b7fbd5832991226bc5a012a0a1f5249ac825e6 

Diff: https://reviews.apache.org/r/20640/diff/


Testing (updated)
---

./gradlew build

e2e test is not quite fixed but the part that caused this error is


Thanks,

Kevin Sweeney

Re: Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20640/#review41253
---


-1 no unit test coverage

- Bill Farner


On April 24, 2014, 1:10 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20640/
> ---
> 
> (Updated April 24, 2014, 1:10 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-349
> https://issues.apache.org/jira/browse/AURORA-349
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix createJob to accept non-cron jobs.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 09b7fbd5832991226bc5a012a0a1f5249ac825e6 
> 
> Diff: https://reviews.apache.org/r/20640/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> e2e test is not quite fixed but the part that caused this error is
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20573/
---

(Updated April 24, 2014, 1:15 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

Rebased with master.


Bugs: AURORA-338
https://issues.apache.org/jira/browse/AURORA-338


Repository: aurora


Description
---

Currently, the getTasks query was only fetching tasks in active status. Updated 
the code to fetching all tasks for getJobSummary.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
4e2dbeb3abfb53f7647e88a1fec95b3ec4590bd7 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 f761feb90c590d4f72323b6bedb15c8d9f715493 

Diff: https://reviews.apache.org/r/20573/diff/


Testing
---

Tested on laptop.


Thanks,

Suman Karumuri

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-23 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20583/
---

(Updated April 24, 2014, 1:33 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

synced master, upgraded pex/commons a few more times.


Repository: aurora


Description
---

Pins twitter.common on 0.3.0 (save twitter.common.python which is released out 
of band.)
Upgrades aurora to twitter.pants 0.0.18 which uses twitter.common.python==0.5.1 
and produces wheels.
Updates the thrift python namespaces so that the autogenerated python artifacts 
do not clobber each other.


Diffs (updated)
-

  3rdparty/python/BUILD 70fb09df4c78a5e22702c054dfe7270bd9636e0f 
  BUILD c075158c7104db84c9eacfd83262e8fd7f120a4c 
  build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 
  pants 56847307fcffb244c1debb14f2250564a9174955 
  pants.ini 5e85d50bc488b2b153a437b946b425f2b512b30e 
  src/main/python/apache/aurora/admin/host_maintenance.py 
6a21ddeb4203a07a04360f68c4a338fe3da52c70 
  src/main/python/apache/aurora/client/api/__init__.py 
ecc3742411b9fed73d6e4cea43da1bc25e2ae97e 
  src/main/python/apache/aurora/client/api/command_runner.py 
f7605f40b5c4ec864a1bae68649f282268260528 
  src/main/python/apache/aurora/client/api/health_check.py 
de7dc69d798e2b90844e95501b4375f90f6e5f94 
  src/main/python/apache/aurora/client/api/instance_watcher.py 
d7db426e6ac712e69eb18a10b6e4cb2da4509aa9 
  src/main/python/apache/aurora/client/api/job_monitor.py 
537e417e074468e169062b73ab207331c51d6a30 
  src/main/python/apache/aurora/client/api/quota_check.py 
c58bc4bfac47f85f674af15845b06d9f2294fe57 
  src/main/python/apache/aurora/client/api/restarter.py 
d060c1b27af2864a33e6524e58b81fe767ec2e98 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
d0e0821a8e8ad38302678ecf686a6028300ebe22 
  src/main/python/apache/aurora/client/api/sla.py 
c381de4f1c8eb289efedce9a4efe93d44f44ff62 
  src/main/python/apache/aurora/client/api/updater.py 
9739af025b810c48f10f65edc2c10da88a8b1a2a 
  src/main/python/apache/aurora/client/base.py 
a33e65ce2b455148d4944d20bbff638dfca7d34a 
  src/main/python/apache/aurora/client/cli/context.py 
957c788c8b073c3711b81a3d56b29b926c717eaa 
  src/main/python/apache/aurora/client/cli/jobs.py 
0534bdf72a332caa606dd3a7ca743a59e03738ef 
  src/main/python/apache/aurora/client/cli/quota.py 
80f7817890c383fec78811ece7d88e90829b067e 
  src/main/python/apache/aurora/client/cli/task.py 
e4ee77ede119fc1e3bd196293965073405bb48b3 
  src/main/python/apache/aurora/client/commands/admin.py 
3765a2eb85c1782f0b86d46bec50043d908bb09f 
  src/main/python/apache/aurora/client/commands/core.py 
67c061eace86b7a28d2c3ae03e23c7d77fc7957f 
  src/main/python/apache/aurora/client/config.py 
855f7091837695658fbcd9003f7f85ee28aacde7 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
48e85143040b41f9337fd562151665bc47bb714f 
  src/main/python/apache/aurora/common/aurora_job_key.py 
a0bc6e5674b6c91442b5619f2dd93afa1aa62e30 
  src/main/python/apache/aurora/common/auth/auth_module.py 
c055036ef2fcfa47fc7e592a284d1d83fe21dc8f 
  src/main/python/apache/aurora/common/auth/auth_module_manager.py 
53b2a3100a094905b3bf093dd7513aaceaadb074 
  src/main/python/apache/aurora/config/schema/base.py 
4a086b31802a0362a6855390dd0d5b431b3a9551 
  src/main/python/apache/aurora/config/thrift.py 
4cc0f0757df6cae387a1f2c293e361dac95e5914 
  src/main/python/apache/aurora/executor/common/task_info.py 
29a05be18febf1a75914b60bc84ad1bd3d629bb1 
  src/main/python/apache/aurora/executor/executor_vars.py 
f358fe5a220e57842f7fbf3d83ffeff35bc9a41e 
  src/main/python/apache/aurora/executor/gc_executor.py 
e860a5808ff8c2f2ffc4070d52af5533209b7e59 
  src/main/python/apache/thermos/testing/runner.py 
0ef4cac3cfb16db91be2eac349852d989fdf4e3f 
  src/main/thrift/org/apache/aurora/gen/BUILD 
dce379cedc0fe025e59dbed6186f650a58bc42c2 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
32596d3da535226e521109a2ae4e5ee112999642 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 
95497aea3d3f769b2460adbfe7a7b72d775ced6f 
  src/test/python/apache/aurora/client/api/test_disambiguator.py 
d964d9165190ebb86e3cd2a866f537c707456126 
  src/test/python/apache/aurora/client/api/test_health_check.py 
d503281ac492a72f49f17b48ba306bc2135f4d05 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
f001ba45ca12332c9a2e18ff5348a0e6ce276926 
  src/test/python/apache/aurora/client/api/test_job_monitor.py 
4ab8a5d68f55c9ace7a9e845edcca5db08990e25 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
b2598ad11f2f4bd5004c61742cc2ba4452e5fd0e 
  src/test/python/apache/aurora/client/api/test_restarter.py 
7a68a9748ce25c45dafc96b936e7c74c10467f9e 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
10c2a90f43fed80e35adbf3604e5655431c1299a 
  src/test/python/apache/aurora/client/api/test_s

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Dave Lester


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/
---

(Updated April 24, 2014, 1:34 a.m.)


Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.


Repository: aurora


Description
---

Renames documentation filenames in associated links to be SEO friendly, per 
AURORA-48.


Diffs
-

  docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
  docs/clientcommands.md  
  docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
  docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
  docs/resourceisolation.md  
  docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
  docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 

Diff: https://reviews.apache.org/r/20641/diff/


Testing
---

Checked that relative links within the markdown documents were updated to 
reflect new filenames.


Thanks,

Dave Lester

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Jake Farrell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/#review41259
---

Ship it!


Ship It!

- Jake Farrell


On April 24, 2014, 1:34 a.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20641/
> ---
> 
> (Updated April 24, 2014, 1:34 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Renames documentation filenames in associated links to be SEO friendly, per 
> AURORA-48.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md  
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/resourceisolation.md  
>   docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
> 
> Diff: https://reviews.apache.org/r/20641/diff/
> 
> 
> Testing
> ---
> 
> Checked that relative links within the markdown documents were updated to 
> reflect new filenames.
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/#review41261
---

Ship it!


Ship It!

- Bill Farner


On April 24, 2014, 1:34 a.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20641/
> ---
> 
> (Updated April 24, 2014, 1:34 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Renames documentation filenames in associated links to be SEO friendly, per 
> AURORA-48.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md  
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/resourceisolation.md  
>   docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
> 
> Diff: https://reviews.apache.org/r/20641/diff/
> 
> 
> Testing
> ---
> 
> Checked that relative links within the markdown documents were updated to 
> reflect new filenames.
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Dave Lester


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/
---

(Updated April 24, 2014, 2:35 a.m.)


Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.


Changes
---

Added bug to bugs field  -wfarner


Bugs: AURORA-48
https://issues.apache.org/jira/browse/AURORA-48


Repository: aurora


Description
---

Renames documentation filenames in associated links to be SEO friendly, per 
AURORA-48.


Diffs
-

  docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
  docs/clientcommands.md  
  docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
  docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
  docs/resourceisolation.md  
  docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
  docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 

Diff: https://reviews.apache.org/r/20641/diff/


Testing
---

Checked that relative links within the markdown documents were updated to 
reflect new filenames.


Thanks,

Dave Lester

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Bill Farner



> On April 24, 2014, 2:31 a.m., Bill Farner wrote:
> > Ship It!

Pushed to master as 94b723b


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20641/#review41261
---


On April 24, 2014, 2:35 a.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20641/
> ---
> 
> (Updated April 24, 2014, 2:35 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-48
> https://issues.apache.org/jira/browse/AURORA-48
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Renames documentation filenames in associated links to be SEO friendly, per 
> AURORA-48.
> 
> 
> Diffs
> -
> 
>   docs/README.md b670c04a8cf398e14e7fad7d00480a973d37968b 
>   docs/clientcommands.md  
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/configurationtutorial.md 9b27fb62ef8f92c241d59d6ae55c27ae7ca8d5a9 
>   docs/resourceisolation.md  
>   docs/tutorial.md 1e7f34cb9fb91f66fc0318f0a24611971a3bd317 
>   docs/userguide.md 2fbafb5d6b340eaf37fa9dd3250b355518538f8e 
> 
> Diff: https://reviews.apache.org/r/20641/diff/
> 
> 
> Testing
> ---
> 
> Checked that relative links within the markdown documents were updated to 
> reflect new filenames.
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/
---

(Updated April 24, 2014, 2:55 a.m.)


Review request for Aurora, Suman Karumuri and Maxim Khutornenko.


Changes
---

Added commas.


Bugs: AURORA-265
https://issues.apache.org/jira/browse/AURORA-265


Repository: aurora


Description
---

AURORA-265: Add missing tooltips for task states in dictionary.js


Diffs (updated)
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 
3db34ecf9a977fe4c84d1d00990d90248b40316e 

Diff: https://reviews.apache.org/r/20146/diff/


Testing
---

Visually inspected the scheduler w/ a sample job to verify that nothing was 
messed up. I'm not sure how to force a task with the Vagrant file into DRAINING 
or THROTTLED states.


Thanks,

Dan Norris

Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/
---

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-340
https://issues.apache.org/jira/browse/AURORA-340


Repository: aurora


Description
---

Remove IsolatedSchedulerModule and surrounding code.


Diffs
-

  build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
  src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 
  src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
1bfd4b69584122f62616ce93098a56fe3cf195d8 
  src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
9186aebef2babc4a76fe05eb3b412be26d7de3c6 
  
src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java 
d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 
  src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
cc31187607e89a9daebe071a8a180d56d873e4c5 

Diff: https://reviews.apache.org/r/20648/diff/


Testing
---

./gradlew build
sh examples/vagrant/test_tutorial.sh


Thanks,

Bill Farner

Review Request 20650: Exclude reports directory from idea project.

2014-04-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
---

IDEA indexes non-excluded directories in dist.  This makes indexing take much 
longer than necesary, and causes bogus results when searching for usages of 
symbols.  This fixes (the majority, at least) both issues.


Diffs
-

  build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 

Diff: https://reviews.apache.org/r/20650/diff/


Testing
---

IDEA no longer goes into as much of an indexing frenzy after running ./gradlew 
build, and searching for symbols does not turn up javadoc HTML and test results.


Thanks,

Bill Farner

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-23 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20650/#review41272
---



build.gradle


Can we add dist/ to this list?


- Suman Karumuri


On April 24, 2014, 5:05 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20650/
> ---
> 
> (Updated April 24, 2014, 5:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> IDEA indexes non-excluded directories in dist.  This makes indexing take much 
> longer than necesary, and causes bogus results when searching for usages of 
> symbols.  This fixes (the majority, at least) both issues.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
> 
> Diff: https://reviews.apache.org/r/20650/diff/
> 
> 
> Testing
> ---
> 
> IDEA no longer goes into as much of an indexing frenzy after running 
> ./gradlew build, and searching for symbols does not turn up javadoc HTML and 
> test results.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-23 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20648/#review41273
---

Ship it!


+1

- Suman Karumuri


On April 24, 2014, 4:22 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20648/
> ---
> 
> (Updated April 24, 2014, 4:22 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-340
> https://issues.apache.org/jira/browse/AURORA-340
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove IsolatedSchedulerModule and surrounding code.
> 
> 
> Diffs
> -
> 
>   build.gradle 459cd85f4f239e19e013e74a4745edc7994a9411 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
>   src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 
> 9a78fb9be8578f8cea2e51c0ebf385aafdc8b2a9 
>   
> src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 
> 1bfd4b69584122f62616ce93098a56fe3cf195d8 
>   src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java 
> 9186aebef2babc4a76fe05eb3b412be26d7de3c6 
>   
> src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java
>  d8f19e6c1eac1567b3194c5d4ebeb0d5b95073e6 
>   src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java 
> cc31187607e89a9daebe071a8a180d56d873e4c5 
> 
> Diff: https://reviews.apache.org/r/20648/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> sh examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

40 matches

Mail list logo