Re: Review Request 22457: Improve aurora job diff command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review46747 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/22457/#comment82306 s/not/be? src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/22457/#comment82311 You may want to use temporary_file() here instead that cleans up after itself: https://github.com/twitter/commons/blob/master/src/python/twitter/common/contextutil/__init__.py#L93-L107 src/test/python/apache/aurora/client/cli/test_diff.py https://reviews.apache.org/r/22457/#comment82312 Would be great to see populated sets here instead of empty arrays. The task.constraints field is the one with nested sets that would be perfect for testing set ordering. src/test/python/apache/aurora/client/cli/test_diff.py https://reviews.apache.org/r/22457/#comment82313 How about local has less tasks than remote test case for completeness? - Maxim Khutornenko On June 26, 2014, 11:42 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 26, 2014, 11:42 a.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-520 https://issues.apache.org/jira/browse/aurora-520 Repository: aurora Description --- Add a new diff method, which uses field-by-field comparison of JSON trees for comparing running job configurations to potentially updated configs. - Allow exclusion of semantically irrelevant fields. - Provide a clearer list of the differences between configs. - Provide a scripting-friendly alternative JSON syntax for diffs. The old diff behavior is still available under the --use-shell-diff option. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/jobs.py 4fa03a6c9919651551238b0dc211ed69a8dfe565 src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION Diff: https://reviews.apache.org/r/22457/diff/ Testing --- New unit tests of the JSON tree diff code, plus a bunch of new job diff tests of the new functionality. All tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 22839: Add configuration plugins to default aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46756 --- src/main/python/apache/aurora/client/cli/standalone_client.py https://reviews.apache.org/r/22839/#comment82319 should this be startswith(--logging-level)? src/main/python/apache/aurora/client/cli/standalone_client.py https://reviews.apache.org/r/22839/#comment82320 len(arg_bits) src/main/python/apache/aurora/client/cli/standalone_client.py https://reviews.apache.org/r/22839/#comment82321 wrap in try/except ValueError src/test/python/apache/aurora/client/cli/test_config_noun.py https://reviews.apache.org/r/22839/#comment82322 kill - Brian Wickman On June 25, 2014, 4:38 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- (Updated June 25, 2014, 4:38 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: aurora-544 and aurora-545 https://issues.apache.org/jira/browse/aurora-544 https://issues.apache.org/jira/browse/aurora-545 Repository: aurora Description --- Add configuration plugins to default aurora client. - Add a plugin to allow users to set logging levels. - Add a plugin to allow users to configure whether or not unknown exceptions get caught or revealed. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 827bbb88230f4e536500710695cb92bf39da3447 src/main/python/apache/aurora/client/cli/standalone_client.py 5d1a4a53a8b36b6dd072485260d490435da6968d src/test/python/apache/aurora/client/cli/test_config_noun.py c55c9fee230002ef749965eb559ee5b309ee143b src/test/python/apache/aurora/client/cli/test_create.py b9313be657ebaf9c79a7695b75abe2d90a7d75dd src/test/python/apache/aurora/client/cli/test_plugins.py ce85318727dcaf22a696d05f99c49b5e953bd3ca src/test/python/apache/aurora/client/cli/util.py a2c9d09c58243250baefab2ee51f5ea3b411 Diff: https://reviews.apache.org/r/22839/diff/ Testing --- - Added new test. - Ran all unit tests. - Did manual command-line testing. Thanks, Mark Chu-Carroll
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46758 --- src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java https://reviews.apache.org/r/22982/#comment82323 This seems like a repeating pattern to avoid naming collision. What do we get with java version that is not provided by guava? - Maxim Khutornenko On June 25, 2014, 7:59 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 25, 2014, 7:59 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6 src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4236859a517dd6760885d02439bd70d165d2b860 src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 87059cd321f5c8ebda6c03e04da390a89bc0358f src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 148c611bbe09e1e2198a4beb0583e6d96a6b7421 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java de394ebd0a4f7ac93d1d8d82906a5a0e4d6565ab Diff: https://reviews.apache.org/r/22982/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 22998: Generate wrapper classes for all thrift structs in api.thrift.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22998/#review46759
---
Ship it!
Awesome!
- Maxim Khutornenko
On June 26, 2014, 3:44 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22998/
---
(Updated June 26, 2014, 3:44 a.m.)
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
---
Addressing TODO from build.gradle.
This change also causes two changes to existing generated classes:
- Accessor methods of type {List,Set,Map} now return Immutable{List,Set,Map}
- isSet* methods are generated for all fields (not sure why this wasn't the
case before)
Here's a full diff of generated sources after this change:
$ for file in `find . -type f`; do diff $file ../new/$file; done
117a118,121
public boolean isSetCronCollisionPolicy() {
return wrapped.isSetCronCollisionPolicy();
}
16,18d15
import java.util.Map;
import java.util.Set;
197c194
public SetIConstraint getConstraints() {
---
public ImmutableSetIConstraint getConstraints() {
205c202
public SetString getRequestedPorts() {
---
public ImmutableSetString getRequestedPorts() {
213c210
public MapString, String getTaskLinks() {
---
public ImmutableMapString, String getTaskLinks() {
237c234
public SetIMetadata getMetadata() {
---
public ImmutableSetIMetadata getMetadata() {
84a85,88
public boolean isSetValue() {
return wrapped.isSetValue();
}
88a93,96
public boolean isSetLimit() {
return wrapped.isSetLimit();
}
16,17d15
import java.util.Set;
99c97
public SetString getValues() {
---
public ImmutableSetString getValues() {
Diffs
-
build.gradle bcecb43308a654e79db5cbd0ba973b2410b00de9
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
9dc92fd486b1166bcf3d14b7806323002aa9f8d2
Diff: https://reviews.apache.org/r/22998/diff/
Testing
---
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 22999: Use immutable types in AttributeStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/#review46761 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2014, 4:45 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/ --- (Updated June 26, 2014, 4:45 a.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository: aurora Description --- Prep work for replacing MemAttributeStore with a database-backed store. Immutable types aren't strictly necessary, but it's a good change to make. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67 src/main/java/org/apache/aurora/scheduler/base/Conversions.java 02e57acae30b1b1ea6ef7f041902ab319b5ef88b src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 06e402ddf10a10953b74ac6d764fa3f614c4d9b9 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 589cab3467d0856444b767bd1e1a48b63c6c2d42 src/main/java/org/apache/aurora/scheduler/http/Maintenance.java d780ed699199751c8afb80f761e1ed957912c8c1 src/main/java/org/apache/aurora/scheduler/http/Slaves.java 4c26db425e56bd83612843ad4f78f3005c03b8d1 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 332598f5fd6a9307b3fb853ffb0494146cc78484 src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 6aa3e1b4c39da1c32eafb796a940fe9f0478cd2d src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6b0068cecead659cdde1129bf53616bcce95e578 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39f47127602a7927f07156a1b4c8d009b428f814 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 0b4e22a02c06adc711ec60b172a1075efb9d49f7 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 796dca3c66e4e389c7d9cf56a12eaee854309f7b src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java ff9e45cca6f38ba33398a40ebf48759b98662034 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java da4eefab7db1f7ac476f81c3aea090638d0aa521 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3578bb35aa642b0679ee017b79dbcf6591235d94 src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java e2d9298e4da97b0934fd39a0f315ec0271efde16 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java c2c05cd21c8c51b8cf92e28925fd8b6cdae0036e src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 4656317405506291ee13a7b760f24a6f832f2754 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 53e5749fe4f9ca573d5930a05f3952cb92dbd843 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 5763fd0cb5ef4871e60a7d46d5e14e93e417c689 Diff: https://reviews.apache.org/r/22999/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46770 --- replace Preconditions.checkNotNull with Objects.requireNonNull as well? - Kevin Sweeney On June 25, 2014, 12:59 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 25, 2014, 12:59 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6 src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4236859a517dd6760885d02439bd70d165d2b860 src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 87059cd321f5c8ebda6c03e04da390a89bc0358f src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 148c611bbe09e1e2198a4beb0583e6d96a6b7421 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java de394ebd0a4f7ac93d1d8d82906a5a0e4d6565ab Diff: https://reviews.apache.org/r/22982/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
On June 26, 2014, 4:59 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 96 https://reviews.apache.org/r/22982/diff/1/?file=617559#file617559line96 This seems like a repeating pattern to avoid naming collision. What do we get with java version that is not provided by guava? In general, i see lightening our dependence on third-party libraries as a Good Thing. It's also likely that guava will eventually remove features that have been adopted by the JDK. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46758 --- On June 25, 2014, 7:59 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 25, 2014, 7:59 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6 src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4236859a517dd6760885d02439bd70d165d2b860 src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 87059cd321f5c8ebda6c03e04da390a89bc0358f src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 148c611bbe09e1e2198a4beb0583e6d96a6b7421 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java de394ebd0a4f7ac93d1d8d82906a5a0e4d6565ab Diff: https://reviews.apache.org/r/22982/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
On June 26, 2014, 6:21 p.m., Kevin Sweeney wrote: replace Preconditions.checkNotNull with Objects.requireNonNull as well? Great suggestion, i'll update the diff to add that. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46770 --- On June 25, 2014, 7:59 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 25, 2014, 7:59 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6 src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 4236859a517dd6760885d02439bd70d165d2b860 src/main/java/org/apache/aurora/scheduler/state/SideEffect.java 87059cd321f5c8ebda6c03e04da390a89bc0358f src/main/java/org/apache/aurora/scheduler/state/TransitionResult.java 148c611bbe09e1e2198a4beb0583e6d96a6b7421 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java de394ebd0a4f7ac93d1d8d82906a5a0e4d6565ab Diff: https://reviews.apache.org/r/22982/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19796/#review46789 --- Ship it! Ship It! - Bill Farner On June 26, 2014, 3:23 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19796/ --- (Updated June 26, 2014, 3:23 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution Moves testing dependencies out of main src into test. Diffs - build.gradle be2ff053f5bba4248a1ddc2f67b4f055e4e3f841 src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java Diff: https://reviews.apache.org/r/19796/diff/ Testing --- Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and created dists with no issues. Thanks, Jake Farrell
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 7:52 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs (updated) - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67 src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815 src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507 src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java d29fbd4f9a3d7fe813f2f105669cf63322efe758 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 589cab3467d0856444b767bd1e1a48b63c6c2d42
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46794 --- Ship it! Ship It! - Joe Smith On June 25, 2014, 11:48 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 25, 2014, 11:48 a.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703 src/main/python/apache/aurora/client/commands/admin.py 02d055f58e6a9bf906bc65a8cc4899e653c1679f src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Review Request 23087: Fix build break in code generator.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23087/
---
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
---
Fixes these compile errors:
:compileGeneratedJava
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:35:
error: cannot find symbol
private final ImmutableSetIScheduleStatus statuses;
^
symbol: class IScheduleStatus
location: class ITaskQuery
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:144:
error: cannot find symbol
public ImmutableSetIScheduleStatus getStatuses() {
^
symbol: class IScheduleStatus
location: class ITaskQuery
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:49:
error: cannot find symbol
? ImmutableSet.IScheduleStatusof()
^
symbol: class IScheduleStatus
location: class ITaskQuery
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors
Diffs
-
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
d16cfddc7163aaedbdc2406bb5f3091b3c65ccbd
Diff: https://reviews.apache.org/r/23087/diff/
Testing
---
$ git clean -fdx
$ ./gradlew clean build -Pq
Thanks,
Bill Farner
Re: Review Request 23087: Fix build break in code generator.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23087/#review46795
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 26, 2014, 7:59 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23087/
---
(Updated June 26, 2014, 7:59 p.m.)
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
---
Fixes these compile errors:
:compileGeneratedJava
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:35:
error: cannot find symbol
private final ImmutableSetIScheduleStatus statuses;
^
symbol: class IScheduleStatus
location: class ITaskQuery
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:144:
error: cannot find symbol
public ImmutableSetIScheduleStatus getStatuses() {
^
symbol: class IScheduleStatus
location: class ITaskQuery
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:49:
error: cannot find symbol
? ImmutableSet.IScheduleStatusof()
^
symbol: class IScheduleStatus
location: class ITaskQuery
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors
Diffs
-
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py
d16cfddc7163aaedbdc2406bb5f3091b3c65ccbd
Diff: https://reviews.apache.org/r/23087/diff/
Testing
---
$ git clean -fdx
$ ./gradlew clean build -Pq
Thanks,
Bill Farner
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46796 --- Latest diff is bad, i managed to pick up some python code with my find/sed. Fix coming up. - Bill Farner On June 26, 2014, 7:52 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 7:52 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67 src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815 src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507 src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java d29fbd4f9a3d7fe813f2f105669cf63322efe758
Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 26, 2014, 8:14 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Changes --- Rebased. Bugs: AURORA-542 https://issues.apache.org/jira/browse/AURORA-542 Repository: aurora Description --- Changing maintenance command to drain SLA-compliant hosts in a group. Diffs (updated) - src/main/python/apache/aurora/admin/admin_util.py d8517e93c9f2d62703b32c304f4b0c415f6343d7 src/main/python/apache/aurora/admin/host_maintenance.py 3c04773b4eb3fbbca3c41443c571d82c77ec7d58 src/main/python/apache/aurora/client/commands/admin.py 022e3d60c6f2c9c795884577503b052ede6635ba src/main/python/apache/aurora/client/commands/maintenance.py e2ac59a60b5ac99cad464b1b4a74082514a1d9e0 src/test/python/apache/aurora/admin/test_host_maintenance.py 8abce0e69d391950f7134af68307308743b9b405 src/test/python/apache/aurora/client/commands/test_admin_sla.py be380dfbbc2feed9b366305cdbae48929b34d2d3 src/test/python/apache/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 8:33 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Reverted python changes caused by overly-aggressive intellij import optimize. Repository: aurora Description --- Use java.util.Objects replacements for guava helpers. Diffs (updated) - src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 2c827fe9ae5bfc941dcf3fd23e4f88d152342f1d src/main/java/org/apache/aurora/scheduler/Driver.java ffedfc313bec4671f95fa4d83ad0a1df58a5fd1f src/main/java/org/apache/aurora/scheduler/DriverFactory.java 0f40112c48c64300f35106a8a2f81d10b2ff8673 src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 0dce5c4a914a8e541815117064b046659e3a60df src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 979b4bb8103634d11885ca8cdf82de8543a61cd3 src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java d96e34a5d9c1b8839f2d1e8c74fd65d7107443ac src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67 src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java f79b0fa507d0b8e0f8f333cd026df73f95c4319f src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0b37442efcc006f9d231c1f9751dc23483af815 src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java dc99ddc89f16642588670538b478099f69cd2ca7 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java a70f81795465595fb81430e3faa004f4eb12a0c2 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 1fff2b3a9e50e88a94c69beed7ab312c0fc8d711 src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java cf22e9c3cbff8e9a4a6197f38e7fe45da6ccc119 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 6ad733c71adb0220fa0c73279871b09265359881 src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 8a8e6e2a304bfd89d1f0ec2ab788fa07d7d3ed92 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 57ed758b537f8fdcc1ccf04236cfb5e9c201e628 src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java d21856f6bf5e5dbd4f3daffeee7a2b3f797e573f src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 0b637216fe1ccff9841684913152ed8e036f795a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 48b36c28b67866d45bcd29354c80429e36102bd4 src/main/java/org/apache/aurora/scheduler/base/Query.java cfb1d16f05431daa5a900efbb575f033e53282a8 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 47cb70bb092a20971e81c867218836d8bd9fbdef src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 1d557c7856d8a0092b77f5ff911dd72e071d1916 src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java 6f01a6939ef7a18154af66a98287229fe1a7f923 src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 17ac2860ba00f031cde68f1e177c8d1072402af3 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 57d874baf57732b1b78c12773f1c0b984a284836 src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 311bcb3cac883c8c0429ddf9f6bac8366e35f5ec src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 9eda3b7baafd81bd8535a73df74131cedc0797eb src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 02ba94a81633a210a69064fd7ac7f71d3559d734 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java a2f099a27e2da73ae2ac9ded04fa258e4f5846c4 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 5b24b31a59ef602baae1f7a6e6c7ce2a2165b507 src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 25c81b9695692b5c4402ebb95c5e5c36594a29b9 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 29fe32b469068e8850b71ac71f7b77294e1b7121 src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 2afbef8f0dba0a8d246f4435d792771a78d5dd31 src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java d29fbd4f9a3d7fe813f2f105669cf63322efe758 src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java b206830a38f3f6e2265f6d742c891f4cf85094b6
Re: Review Request 22999: Use immutable types in AttributeStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/ --- (Updated June 26, 2014, 8:37 p.m.) Review request for Aurora and Maxim Khutornenko. Changes --- People -= davmclau, who is on vacation. Repository: aurora Description --- Prep work for replacing MemAttributeStore with a database-backed store. Immutable types aren't strictly necessary, but it's a good change to make. Diffs - src/main/java/org/apache/aurora/scheduler/TaskVars.java 75e791709262319a45c1dacd768708e3a2122f67 src/main/java/org/apache/aurora/scheduler/base/Conversions.java 02e57acae30b1b1ea6ef7f041902ab319b5ef88b src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 1afc6ca036e7f52f81775f029779badfb36e09db src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 06e402ddf10a10953b74ac6d764fa3f614c4d9b9 src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 0a76e43ee6f014132bdd6e7f63395335af068846 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 589cab3467d0856444b767bd1e1a48b63c6c2d42 src/main/java/org/apache/aurora/scheduler/http/Maintenance.java d780ed699199751c8afb80f761e1ed957912c8c1 src/main/java/org/apache/aurora/scheduler/http/Slaves.java 4c26db425e56bd83612843ad4f78f3005c03b8d1 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 332598f5fd6a9307b3fb853ffb0494146cc78484 src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 6aa3e1b4c39da1c32eafb796a940fe9f0478cd2d src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6b0068cecead659cdde1129bf53616bcce95e578 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 39f47127602a7927f07156a1b4c8d009b428f814 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 0b4e22a02c06adc711ec60b172a1075efb9d49f7 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 796dca3c66e4e389c7d9cf56a12eaee854309f7b src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java ff9e45cca6f38ba33398a40ebf48759b98662034 src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java da4eefab7db1f7ac476f81c3aea090638d0aa521 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 3578bb35aa642b0679ee017b79dbcf6591235d94 src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java e2d9298e4da97b0934fd39a0f315ec0271efde16 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java c2c05cd21c8c51b8cf92e28925fd8b6cdae0036e src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java 4656317405506291ee13a7b760f24a6f832f2754 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 53e5749fe4f9ca573d5930a05f3952cb92dbd843 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 5763fd0cb5ef4871e60a7d46d5e14e93e417c689 Diff: https://reviews.apache.org/r/22999/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 22948: Add a script that allows for easy selective rebuilding of components in the vagrant environment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22948/#review46808 --- Ping - Kevin, Mark? - Bill Farner On June 25, 2014, 12:43 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22948/ --- (Updated June 25, 2014, 12:43 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim Khutornenko. Repository: aurora Description --- Some context for this review can be found in: https://reviews.apache.org/r/20648/ https://reviews.apache.org/r/22008/ This is a step towards making it simpler to iterate on code in the vagrant environment. If i'm developing on the observer, i can make my edits and then run: $ vagrant ssh -c 'aurorabuild observer' Diffs - examples/vagrant/aurorabuild.sh PRE-CREATION examples/vagrant/provision-dev-cluster.sh f6459a15887299038165f0e0dde22015392e0d0f Diff: https://reviews.apache.org/r/22948/diff/ Testing --- vagrant up bash examples/vagrant/test_tutorial.sh I will update this section once i have run end-to-end tests, and will not submit until this section is updated. Thanks, Bill Farner
Review Request 23107: Database-backed implementation of SchedulerStore.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-555 https://issues.apache.org/jira/browse/AURORA-555 Repository: aurora Description --- Database-backed implementation of SchedulerStore. Diffs - src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 48b4404590d393cda393b8cc7bc0619934a75223 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java e23506b7a3546c896f3095c80e3a20a97bee77d3 src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 0e7f52c83fb450f631751a635fd4d85fc61e3bab src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 1738b95cd67cf990bd8aad8c744a1febe2d87f15 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java c683e398640c7ebf2047ef308a701cb4897c58dc src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 505c94d6800c1453b1b1f696ef774f5943973f19 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 083e3ffa9add639666c2a3bcad478678886c643f src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 65750b61b864f0e830513039a7c9d727ac9d493d src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 23555c2483d7fe716243847f8478898e98fb5ac4 src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 3298eb38644b6fa7096801a69f8b88d0331ce4a7 src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 57095cea18936fb2ddf92bce587aea58e81996c8 src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 22a40481b5b246989c2e17a72a0325649382dde1 Diff: https://reviews.apache.org/r/23107/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
