Re: Review Request 25505: Make aurora job status JSON output more friendly.

2014-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52902 --- Since you are touching this code, mind fixing the error when no

Re: Review Request 25505: Make aurora job status JSON output more friendly.

2014-09-10 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/ --- (Updated Sept. 10, 2014, 3:34 p.m.) Review request for Aurora, David

Re: Review Request 25505: Make aurora job status JSON output more friendly.

2014-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52926 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 10, 2014, 7:34

Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/ --- Review request for Aurora, Mark Chu-Carroll and Zameer Manji. Bugs: AURORA-692

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52929 --- Ship it! Thanks for doing this so quickly. - Zameer Manji On

Re: Review Request 25505: Make aurora job status JSON output more friendly.

2014-09-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52930 --- Ship it! Ship It! - Zameer Manji On Sept. 10, 2014, 12:34 p.m.,

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52945 --- can you also add e2e test coverage? - Joe Smith On Sept. 10,

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25398/#review52958 --- Ship it! Ship It! - Bill Farner On Sept. 9, 2014, 4:54 p.m.,

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Maxim Khutornenko
On Sept. 10, 2014, 9:09 p.m., Joe Smith wrote: can you also add e2e test coverage? Great idea. We need to start adding admin integration tests at some point and why not now: ```... == Testing Aurora Admin commands... + echo '== Getting leading scheduler' == Getting leading scheduler +

Re: Review Request 25398: Make the offer hold jitter window configurable.

2014-09-10 Thread Bill Farner
On Sept. 10, 2014, 10:15 p.m., Bill Farner wrote: Ship It! Thanks! This is now on master: ``` commit cc70136 Author: Joshua Cohen jco...@twopensource.com Date: Wed Sep 10 15:38:56 2014 -0700 Make the offer hold jitter window configurable. Bugs closed: AURORA-313

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52968 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2014, 3:43 p.m.,

Review Request 25529: Add a controller for job updates.

2014-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and