---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26269/
---
Review request for Aurora and David McLaughlin.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/
---
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-781
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26269/#review55212
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 2, 2014, 3:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26269/#review55213
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 2, 2014, 8:48 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/#review55217
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 2, 2014, 9:07 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/
---
(Updated Oct. 2, 2014, 2:24 p.m.)
Review request for Aurora, David McLaughlin
On Oct. 2, 2014, 2:54 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java,
line 85
https://reviews.apache.org/r/26232/diff/2/?file=710417#file710417line85
I'm always nervous when important behavior is embedded in something
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26232/
---
(Updated Oct. 2, 2014, 7:40 p.m.)
Review request for Aurora, David McLaughlin
On Oct. 2, 2014, 2:54 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java, line
147
https://reviews.apache.org/r/26232/diff/2/?file=710418#file710418line147
Keep the value rich as far down as you can, to mitigate accidental
misuse:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/#review55239
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 2, 2014, 6:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26232/
---
(Updated Oct. 2, 2014, 7:54 p.m.)
Review request for Aurora, David McLaughlin
On Sept. 30, 2014, 2:32 a.m., Joe Smith wrote:
src/main/python/apache/aurora/client/cli/update.py, line 45
https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45
Could you update a test case to catch accessing these as properties to
catch accidental regressions?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26004/
---
(Updated Oct. 2, 2014, 4:41 p.m.)
Review request for Aurora, David McLaughlin
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
src/main/python/apache/aurora/client/cli/update.py, line 45
https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45
Could you update a test case to catch accessing these as properties to
catch accidental regressions?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26283/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-566
On Oct. 1, 2014, 4:34 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/executor/common/announcer.py, line 228
https://reviews.apache.org/r/25974/diff/6/?file=709964#file709964line228
push this into `__start`, out of the constructor?
At least on the Java side we
On Oct. 1, 2014, 4:14 p.m., Brian Wickman wrote:
src/test/python/apache/aurora/executor/common/test_announcer.py, line 239
https://reviews.apache.org/r/25974/diff/6/?file=709965#file709965line239
out of scope for this review, but there's a new-ish pypi project called
'zake' that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26288/
---
Review request for Aurora and Mark Chu-Carroll.
Bugs: AURORA-786
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26283/#review55265
---
Ship it!
Ship It!
- Bill Farner
On Oct. 2, 2014, 9:44 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26232/#review55266
---
Ship it!
On Oct. 2, 2014, 10:39 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPruner.java,
line 89
https://reviews.apache.org/r/26232/diff/4/?file=711547#file711547line89
if (!prunedUpdates.isEmpty()) {
LOG.info(...);
}
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26232/
---
(Updated Oct. 2, 2014, 10:51 p.m.)
Review request for Aurora, David McLaughlin
On Oct. 1, 2014, 4:34 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/executor/common/announcer.py, line 228
https://reviews.apache.org/r/25974/diff/6/?file=709964#file709964line228
push this into `__start`, out of the constructor?
At least on the Java side we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/
---
(Updated Oct. 2, 2014, 4:20 p.m.)
Review request for Aurora, Kevin Sweeney,
On Oct. 2, 2014, 11:16 p.m., David McLaughlin wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml,
lines 468-490
https://reviews.apache.org/r/26232/diff/5/?file=713015#file713015line468
It'd be nice if this didn't just blanket delete all
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/
---
Review request for Aurora, Vinod Kone and Brian Wickman.
Bugs: AURORA-788
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26298/
---
Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko.
Repository:
On Oct. 3, 2014, 12:13 a.m., Maxim Khutornenko wrote:
| I also changed the test to avoid sleeping, which was eating a fixed 10
seconds of unit test time.
Not really sure why it takes that long for you:
$ time ./pants src/test/python/apache/aurora/client/api:scheduler_client -k
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26298/
---
(Updated Oct. 3, 2014, 12:18 a.m.)
Review request for Aurora, Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26298/#review55295
---
src/main/python/apache/aurora/client/api/scheduler_client.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26244/#review55296
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 1, 2014, 7:25 p.m.,
On Oct. 3, 2014, 12:21 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/api/scheduler_client.py, line 286
https://reviews.apache.org/r/26298/diff/1/?file=713279#file713279line286
Why not just add a break into the Exception catcher instead?
Actually, we are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55299
---
Ship it!
http://media.giphy.com/media/7LG6PqAubrWBa/giphy.gif
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review55309
---
src/test/python/apache/aurora/executor/common/test_announcer.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/
---
(Updated Oct. 2, 2014, 6:44 p.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55312
---
Upon discussion with Vinod Kone and Ben Mahler this doesn't seem
On Oct. 3, 2014, 12:21 a.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/api/scheduler_client.py, line 286
https://reviews.apache.org/r/26298/diff/1/?file=713279#file713279line286
Why not just add a break into the Exception catcher instead?
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 3, 2014, 2:38 a.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55319
---
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 3, 2014, 4:52 a.m.)
Review request for Aurora, Kevin Sweeney and
40 matches
Mail list logo
