Re: Review Request 27375: Remove dependency on application-http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375/#review59420 --- Ship it! Master (765f2dd) is green with this patch. ./build-suppo

Re: Review Request 27375: Remove dependency on application-http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375/ --- (Updated Oct. 31, 2014, 9:03 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 27375: Remove dependency on application-http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27375/ --- (Updated Oct. 31, 2014, 9:02 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 27375: Remove dependency on application-http.

> On Oct. 30, 2014, 6:15 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/QuitCallback.java, line 37 > > > > > > to shutdown? Done. - Bill --

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59412 --- Ship it! Master (02a1c04) is green with this patch. ./build-suppo

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/ --- (Updated Oct. 31, 2014, 8:31 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

> On Oct. 30, 2014, 5:29 p.m., Kevin Sweeney wrote: > > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line > > 89 > > > > > > looks like your sentence got cut off here - the > > legacyClassesW

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

> On Oct. 30, 2014, 3:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 212 > > > > > > s/public// Done. I also realized the constructor injection was a hack

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

> On Oct. 30, 2014, 5 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java, line > > 58 > > > > > > Each test is invoking this method, then accessing the injector instance