Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226 https://reviews.apache.org/r/27705/diff/2/?file=763034#file763034line226 To get the data we want, some extra analysis is needed. Specifically - if we want to figure

Review Request 28048: Fix task_util dependency and add it to all target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28048/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 28048: Fix task_util dependency and add it to all target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28048/#review61475 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 14, 2014, 7 p.m.,

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226 https://reviews.apache.org/r/27705/diff/2/?file=763034#file763034line226 To get the data we want, some extra analysis is needed. Specifically - if we want to figure

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review61506 --- Ship it! Ship It! - David McLaughlin On Nov. 14, 2014, 1:30

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27698/#review61513 --- Ship it!

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27698/ --- (Updated Nov. 14, 2014, 9:58 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 27852: Ensure run verb returns an exit code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27852/ --- (Updated Nov. 14, 2014, 2:15 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27852: Ensure all verbs return an exit code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27852/ --- (Updated Nov. 14, 2014, 2:16 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 14, 2014, 10:16 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 27852: Ensure all verbs return an exit code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27852/#review61527 --- Ship it! Master (8741cdb) is green with this patch.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61529 --- This patch does not apply cleanly on master (8741cdb), do you need

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61525 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61537 --- Ship it! Ship It! - Zameer Manji On Nov. 14, 2014, 2:16 p.m.,

Re: Review Request 28021: Remove dependency on commons-lang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28021/#review61564 --- Ship it! Ship It! - Joshua Cohen On Nov. 14, 2014, 1:07 a.m.,

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

On Nov. 14, 2014, 10:46 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 64 https://reviews.apache.org/r/27705/diff/3/?file=764035#file764035line64 Please define static and dynamic vetos in a comment here. Thanks for reminding. Meant to do

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 15, 2014, 12:15 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61578 --- Master (8741cdb) is red with this patch.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61586 --- Ship it! Master (8741cdb) is green with this patch.

Review Request 28066: Fixing flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28066/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-798

Re: Review Request 28066: Fixing flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28066/#review61587 --- Master (8741cdb) is red with this patch.

Re: Review Request 28021: Remove dependency on commons-lang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28021/#review61588 --- Ship it! Ship It! - Kevin Sweeney On Nov. 13, 2014, 5:07 p.m.,

Re: Review Request 28066: Fixing flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28066/ --- (Updated Nov. 15, 2014, 1:53 a.m.) Review request for Aurora and Kevin

Re: Review Request 28021: Remove dependency on commons-lang.

On Nov. 14, 2014, 5:16 p.m., Kevin Sweeney wrote: Ship It! Kevin, can you please commit this? Thanks. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28021/#review61588

Re: Review Request 28066: Fixing flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28066/#review61610 --- Ship it! Master (8741cdb) is green with this patch.