---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review64578
---
Ship it!
Ship It!
- Bill Farner
On Dec. 10, 2014, 1:22 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28617/#review64609
---
Heads up - i'm focusing on https://reviews.apache.org/r/28731/
On Dec. 9, 2014, 3:29 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 384
https://reviews.apache.org/r/28876/diff/1/?file=787343#file787343line384
This solution seems to be papering over the problem we have with output
in the client.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/
---
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/
---
(Updated Dec. 10, 2014, 7:41 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28831/#review64612
---
Ship it!
- Bill Farner
On Dec. 9, 2014, 8:18 p.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-967
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28913/#review64615
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/#review64617
---
config/pmd/design.xml
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/
---
(Updated Dec. 10, 2014, 8:02 p.m.)
Review request for Aurora, Kevin Sweeney
On Dec. 10, 2014, 8 p.m., Kevin Sweeney wrote:
config/pmd/design.xml, lines 1914-1915
https://reviews.apache.org/r/28914/diff/1/?file=788485#file788485line1914
Fix description?
Yup, just noticed and updated.
- Maxim
---
On Dec. 10, 2014, 8:01 p.m., Kevin Sweeney wrote:
config/pmd/design.xml, line 1909
https://reviews.apache.org/r/28914/diff/1/?file=788485#file788485line1909
Also, consider adding this to a custom.xml file.
Good idea. Done.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/
---
(Updated Dec. 10, 2014, 8:06 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/#review64623
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/#review64624
---
config/pmd/custom.xml
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/#review64631
---
Ship it!
config/pmd/design.xml
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28915/
---
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28915/#review64643
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28915/#review64646
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28915/#review64648
---
Ship it!
Ship It!
- Kevin Sweeney
On Dec. 10, 2014, 1:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
Review request for Aurora.
Summary (updated)
-
Add support
On Dec. 10, 2014, 9:07 p.m., Bill Farner wrote:
config/pmd/design.xml, line 1923
https://reviews.apache.org/r/28914/diff/2/?file=788486#file788486line1923
Should this be =1? JDK8 supports multiple annotations of the same
type, so while silly it might be good to keep in mind.
On Dec. 10, 2014, 8:31 p.m., Kevin Sweeney wrote:
config/pmd/custom.xml, line 21
https://reviews.apache.org/r/28914/diff/3/?file=788487#file788487line21
Name = Aurora?
Sure.
On Dec. 10, 2014, 8:31 p.m., Kevin Sweeney wrote:
config/pmd/custom.xml, line 15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/
---
(Updated Dec. 10, 2014, 10:37 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28915/#review64651
---
Ship it!
Ship It!
- Maxim Khutornenko
On Dec. 10, 2014, 9:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28914/#review64654
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review64657
---
Ship it!
Master (2aac148) is green with this patch.
On Dec. 9, 2014, 11:29 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 384
https://reviews.apache.org/r/28876/diff/1/?file=787343#file787343line384
This solution seems to be papering over the problem we have with output
in the client.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/
---
(Updated Dec. 11, 2014, 2:54 a.m.)
Review request for Aurora, Kevin Sweeney
On Dec. 9, 2014, 11:41 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/api/test_quota_check.py, line 124
https://reviews.apache.org/r/28872/diff/1/?file=787283#file787283line124
Can you set all the calls to print quota?
Sure, done.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/
---
(Updated Dec. 11, 2014, 2:55 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64676
---
Ship it!
Ship It!
- Zameer Manji
On Dec. 10, 2014, 6:55 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28876/#review64677
---
Ship it!
Ship It!
- Zameer Manji
On Dec. 9, 2014, 2:32 p.m.,
On Dec. 9, 2014, 3:29 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/cli/test_update.py, line 69
https://reviews.apache.org/r/28876/diff/1/?file=787345#file787345line69
Is it at all possible to avoid the use of raw Mock objects?
Maxim Khutornenko wrote:
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28872/#review64683
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Dec. 11, 2014, 6:16 a.m.)
Review request for Aurora, Jay Buffington,
36 matches
Mail list logo