Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review64578 --- Ship it! Ship It! - Bill Farner On Dec. 10, 2014, 1:22 a.m.,

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/#review64609 --- Heads up - i'm focusing on https://reviews.apache.org/r/28731/

Re: Review Request 28876: Suppressing redundant client command error messaging.

2014-12-10 Thread Zameer Manji
On Dec. 9, 2014, 3:29 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 384 https://reviews.apache.org/r/28876/diff/1/?file=787343#file787343line384 This solution seems to be papering over the problem we have with output in the client.

Review Request 28913: Remove SANDBOX_DELETED state.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28913/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository:

Re: Review Request 28913: Remove SANDBOX_DELETED state.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28913/ --- (Updated Dec. 10, 2014, 7:41 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28831: Changing the default --batch-size to 1.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28831/#review64612 --- Ship it! - Bill Farner On Dec. 9, 2014, 8:18 p.m., Maxim

Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-967

Re: Review Request 28913: Remove SANDBOX_DELETED state.

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28913/#review64615 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64617 --- config/pmd/design.xml

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- (Updated Dec. 10, 2014, 8:02 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
On Dec. 10, 2014, 8 p.m., Kevin Sweeney wrote: config/pmd/design.xml, lines 1914-1915 https://reviews.apache.org/r/28914/diff/1/?file=788485#file788485line1914 Fix description? Yup, just noticed and updated. - Maxim ---

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
On Dec. 10, 2014, 8:01 p.m., Kevin Sweeney wrote: config/pmd/design.xml, line 1909 https://reviews.apache.org/r/28914/diff/1/?file=788485#file788485line1909 Also, consider adding this to a custom.xml file. Good idea. Done. - Maxim

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- (Updated Dec. 10, 2014, 8:06 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64623 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64624 --- config/pmd/custom.xml

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64631 --- Ship it! config/pmd/design.xml

Review Request 28915: Use pip to pre-fetch python dependencies.

2014-12-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28915/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository:

Re: Review Request 28915: Use pip to pre-fetch python dependencies.

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28915/#review64643 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28915: Use pip to pre-fetch python dependencies.

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28915/#review64646 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28915: Use pip to pre-fetch python dependencies.

2014-12-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28915/#review64648 --- Ship it! Ship It! - Kevin Sweeney On Dec. 10, 2014, 1:39 p.m.,

Review Request 28920: Add support for docker containers to aurora

2014-12-10 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- Review request for Aurora. Summary (updated) - Add support

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
On Dec. 10, 2014, 9:07 p.m., Bill Farner wrote: config/pmd/design.xml, line 1923 https://reviews.apache.org/r/28914/diff/2/?file=788486#file788486line1923 Should this be =1? JDK8 supports multiple annotations of the same type, so while silly it might be good to keep in mind.

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
On Dec. 10, 2014, 8:31 p.m., Kevin Sweeney wrote: config/pmd/custom.xml, line 21 https://reviews.apache.org/r/28914/diff/3/?file=788487#file788487line21 Name = Aurora? Sure. On Dec. 10, 2014, 8:31 p.m., Kevin Sweeney wrote: config/pmd/custom.xml, line 15

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- (Updated Dec. 10, 2014, 10:37 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28915: Use pip to pre-fetch python dependencies.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28915/#review64651 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 10, 2014, 9:39

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64654 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review64657 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28876: Suppressing redundant client command error messaging.

2014-12-10 Thread Maxim Khutornenko
On Dec. 9, 2014, 11:29 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 384 https://reviews.apache.org/r/28876/diff/1/?file=787343#file787343line384 This solution seems to be papering over the problem we have with output in the client.

Re: Review Request 28872: Improving quota check message in the client.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/ --- (Updated Dec. 11, 2014, 2:54 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28872: Improving quota check message in the client.

2014-12-10 Thread Maxim Khutornenko
On Dec. 9, 2014, 11:41 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/api/test_quota_check.py, line 124 https://reviews.apache.org/r/28872/diff/1/?file=787283#file787283line124 Can you set all the calls to print quota? Sure, done. - Maxim

Re: Review Request 28872: Improving quota check message in the client.

2014-12-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/ --- (Updated Dec. 11, 2014, 2:55 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28872: Improving quota check message in the client.

2014-12-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/#review64676 --- Ship it! Ship It! - Zameer Manji On Dec. 10, 2014, 6:55 p.m.,

Re: Review Request 28876: Suppressing redundant client command error messaging.

2014-12-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28876/#review64677 --- Ship it! Ship It! - Zameer Manji On Dec. 9, 2014, 2:32 p.m.,

Re: Review Request 28876: Suppressing redundant client command error messaging.

2014-12-10 Thread Zameer Manji
On Dec. 9, 2014, 3:29 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_update.py, line 69 https://reviews.apache.org/r/28876/diff/1/?file=787345#file787345line69 Is it at all possible to avoid the use of raw Mock objects? Maxim Khutornenko wrote: This

Re: Review Request 28872: Improving quota check message in the client.

2014-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/#review64683 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-10 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Dec. 11, 2014, 6:16 a.m.) Review request for Aurora, Jay Buffington,