Review Request 30248: Fix a markdown syntax error in the deployment docs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30248/ --- Review request for Aurora. Repository: aurora Description --- Fix a markdown syntax error in the deployment docs Diffs - docs/deploying-aurora-scheduler.md c14f865a844b6eb34cc0e9363dba50d4975f5632 Diff: https://reviews.apache.org/r/30248/diff/ Testing --- Rendered document before and then after. Thanks, Jeffrey Schroeder
Re: Review Request 30248: Fix a markdown syntax error in the deployment docs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30248/#review69549 --- Master (7ba6226) is red with this patch. ./build-support/jenkins/build.sh :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.891683042243 exceeds minimum coverage of 0.89. :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. Branch coverage is 0.8336745138178097, but must be greater than 0.835 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 3 mins 33.626 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 24, 2015, 9:48 p.m., Jeffrey Schroeder wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30248/ --- (Updated Jan. 24, 2015, 9:48 p.m.) Review request for Aurora. Repository: aurora Description --- Fix a markdown syntax error in the deployment docs Diffs - docs/deploying-aurora-scheduler.md c14f865a844b6eb34cc0e9363dba50d4975f5632 Diff: https://reviews.apache.org/r/30248/diff/ Testing --- Rendered document before and then after. Thanks, Jeffrey Schroeder
Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/ --- Review request for Aurora. Repository: aurora Description --- Add CONTRIBUTING.md so github shows a link to it before opening a PR Diffs - CONTRIBUTING.md PRE-CREATION Diff: https://reviews.apache.org/r/30249/diff/ Testing --- I accidentally opened a github pull request to fix a small documentation tyop previously. Per the [github documentation](https://github.com/blog/1184-contributing-guidelines), if you have CONTRIBUTING.md in the root of the project, it will be shown before a user ever opens a pull request. Probably makes sense to prevent people from opening pull requests in the future. Note that this is simply a symlink to docs/contributing.md. Thanks, Jeffrey Schroeder
Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/#review69552 --- I think this is a great idea, it'll definitely help point people to ReviewBoard rather than opening pull requests. That said, as far as I can tell, Github has no special processing for including one markdown doc within another, so presumably this will render literally as the string docs/contributing.md. Can you add a little bit more content to this file so that it says something like, Please see [the contributing guidelines](docs/contributing.md) for details on how to contribute patches to Aurora. - Joshua Cohen On Jan. 24, 2015, 9:53 p.m., Jeffrey Schroeder wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/ --- (Updated Jan. 24, 2015, 9:53 p.m.) Review request for Aurora. Repository: aurora Description --- Add CONTRIBUTING.md so github shows a link to it before opening a PR Diffs - CONTRIBUTING.md PRE-CREATION Diff: https://reviews.apache.org/r/30249/diff/ Testing --- I accidentally opened a github pull request to fix a small documentation tyop previously. Per the [github documentation](https://github.com/blog/1184-contributing-guidelines), if you have CONTRIBUTING.md in the root of the project, it will be shown before a user ever opens a pull request. Probably makes sense to prevent people from opening pull requests in the future. Note that this is simply a symlink to docs/contributing.md. Thanks, Jeffrey Schroeder
Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/#review69550 --- Master (7ba6226) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.config.test_base . SUCCESS src.test.python.apache.aurora.config.test_constraint_parsing . SUCCESS src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . FAILURE src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 24, 2015, 9:53 p.m., Jeffrey Schroeder wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30249/ --- (Updated Jan. 24, 2015, 9:53 p.m.) Review request for Aurora. Repository: aurora Description