Re: Review Request 16170: Revert Thrift upgrade.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16170/#review31756 --- Discarding this. - Kevin Sweeney On Dec. 10, 2013, 5:32 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16170/ --- (Updated Dec. 10, 2013, 5:32 p.m.) Review request for Aurora, Suman Karumuri, Maxim Khutornenko, Bill Farner, and Zameer Manji. Repository: aurora Description --- Revert Upgrade Thrift to 0.9.1 Revert the Thrift upgrade, leaving the compiler flag optimizations in place. The upgrade shadowed libthrift 0.5 dependencies, causing downstream classpath conflicts. This reverts commit e7b3da9c47390ed40aac8a5b17aef6b5a6404274. Diffs - build-support/thrift/Makefile 56e28fd5e12e1cb3363e265012e9cc04ce02bb38 build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9 src/main/java/com/twitter/aurora/scheduler/base/Tasks.java d98da3f9ca8104ebcbed5cdbccaf44ea19b42e2a src/main/java/com/twitter/aurora/scheduler/configuration/ConfigurationManager.java 4839d0f08ae950329378475304f8f3cd09e2a25f src/main/java/com/twitter/aurora/scheduler/cron/testing/AbstractCronIT.java 6bfc9096a6abda9a249c8c7d39ddff0edf73b085 src/main/java/com/twitter/aurora/scheduler/http/SchedulerzJob.java 12b0becd6a998d52d960be84791d06ddfed10989 src/main/java/com/twitter/aurora/scheduler/http/SchedulerzRole.java 756c672461e8794e9ed045e5439c76da6c7d37e0 src/main/java/com/twitter/aurora/scheduler/storage/log/Entries.java 74e8c070d022d36daebcc01f10a41d05292d2296 src/main/java/com/twitter/aurora/scheduler/storage/log/LogManager.java da29401fd623bc69ec807048a0df49604722a82a src/main/java/com/twitter/aurora/scheduler/storage/log/SnapshotStoreImpl.java df6b899ab01e91ef89906aaacddca91e3f0349c9 src/main/java/com/twitter/aurora/scheduler/storage/log/testing/LogOpMatcher.java a4c0126716a81a9687d9578181276e632ac34e37 src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerAPIServlet.java 2acf5c820bc1548640e5f35c0e1d146844722bba src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftInterface.java 503ac447c364340dc7072d15fd3c94532779f7c1 src/main/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftServer.java PRE-CREATION src/main/java/com/twitter/aurora/scheduler/thrift/ThriftModule.java cca9053906ef3d1d59e31a6b1856c1cbb2dc src/main/java/com/twitter/aurora/scheduler/thrift/ThriftServer.java 7b9abd1948e12d9a42b80dd46833d2ea1267a054 src/main/java/com/twitter/aurora/scheduler/thrift/ThriftServerLauncher.java 6743060c4cf98c3b9a94386185faa81eafb74c09 src/main/java/com/twitter/aurora/scheduler/thrift/aop/APIVersionInterceptor.java d66a2b29e5a03f098caa131c1092c6dd5180347c src/test/java/com/twitter/aurora/scheduler/app/SchedulerIT.java 4c381b946c8a3c7bbe1757d384d5d43dd74bb4d0 src/test/java/com/twitter/aurora/scheduler/configuration/ConfigurationManagerTest.java ec9c21c1526a260da474ec1f49ecc3bf55e2da12 src/test/java/com/twitter/aurora/scheduler/state/CronJobManagerTest.java b88ccff2fc86a522ec3d272d763d4ce139ef37c3 src/test/java/com/twitter/aurora/scheduler/state/LockManagerImplTest.java ec0c8dd33c34445f6e67bb655701e596d3424b8a src/test/java/com/twitter/aurora/scheduler/state/StateManagerImplTest.java 7de377c66f000b2a16ace1c3d6883274185e450f src/test/java/com/twitter/aurora/scheduler/storage/backup/RecoveryTest.java ded3a3f2552c133097b5c8147a08b0650e4d0b88 src/test/java/com/twitter/aurora/scheduler/storage/log/LogManagerTest.java d14fb4be9631fcbf832daa489d16a27eee1f43bd src/test/java/com/twitter/aurora/scheduler/storage/log/LogStorageTest.java e2d1836884546a856320aeef3def5811a2f5215e src/test/java/com/twitter/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 506279518ba29601cfe13d20bf6ef175d1407a18 src/test/java/com/twitter/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1e1e7b5a9c2805790ed26939e151b727a15ec88d Diff: https://reviews.apache.org/r/16170/diff/ Testing --- git clean -fdx build-support ./gradlew clean build Thanks, Kevin Sweeney
Review Request 16868: Fix build break caused by a584410.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16868/ --- Review request for Aurora and Jake Farrell. Repository: aurora Description --- Fix build break caused by a584410. Diffs - src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9 src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665 Diff: https://reviews.apache.org/r/16868/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 16868: Fix build break caused by a584410.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16868/#review31805 --- Ship it! Ship It! - Jake Farrell On Jan. 14, 2014, 8:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16868/ --- (Updated Jan. 14, 2014, 8:53 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Repository: aurora Description --- Fix build break caused by a584410. Diffs - src/test/python/apache/aurora/client/commands/test_diff.py 82c3cc66764200cd182d9847e82db80d689826d9 src/test/python/apache/aurora/client/commands/test_update.py 69da11180461c9080ac870322510bdbce4649665 Diff: https://reviews.apache.org/r/16868/diff/ Testing --- ./pants src/test/python:all I have a failure on test_ephemerals: src.test.python.apache.thermos.core.test_ephemerals . FAILURE Confirmed that this test fails before the breaking SHA above, so i suspect it's specific to my machine (given that build is green for others). Thanks, Bill Farner
Re: Review Request 16629: Client quota check (server side)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16629/ --- (Updated Jan. 14, 2014, 11:46 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments addressed. Repository: aurora Description --- Part 2: Server side changes for the client quota check. Refactored quota manager: - Merged QuotaFilter with QuotaManager and dropped JobFilter implementation; - Simplified quota manager logic by splitting data retrieval and quota checking steps; - Moved quota checks into write transaction to ensure consistency. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 785efd09a65568b174b35376c550ba5290e5915a src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java 99d2e4c72621708c971d25ad4e6722e0870093af src/main/java/org/apache/aurora/scheduler/quota/QuotaFilter.java 6ab79820a0634478c0525d7fdd5a4d002ef8ea08 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 6b0645ba93e50b576f7e572d8dc06231636fade2 src/main/java/org/apache/aurora/scheduler/quota/QuotaModule.java 4a619492f6e9eb41e693353187fc3b1781bffc1f src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 24f209339f3a6f4659693986e220187bd34d2fb5 src/main/java/org/apache/aurora/scheduler/state/JobFilter.java 0d84c1e2eff781e7d0250967ae6b9f9473fde3dc src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 8dec2831444a21125d250d98132aae1009b0e306 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 79f56052a25ba756208e747dc5d198f30f0c4900 src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 8fb51d69be6d370f9f010c797b2c1205b38a04f5 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 76caa6214dc53c79222bc4a1b9e5066b61839ec6 src/test/java/org/apache/aurora/scheduler/quota/QuotaComparisonResultTest.java 23069b8d191f1675636bceb8c297ebcc0d88d8dc src/test/java/org/apache/aurora/scheduler/quota/QuotaFilterTest.java b1d878ea91c02ba87059b05877208b702d3fbcae src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f971aa1882e5e9f4208d177566779f5dd12d70ce src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 4eeed38244904b64352ecc6c3b66b2d0ced9 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b46f29ad6cd1dd69fe31e73f2b8000dbf88508ea src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java cce27a0e37452f370a3729b6b05bf0bea29f85f6 Diff: https://reviews.apache.org/r/16629/diff/ Testing --- gradle build Thanks, Maxim Khutornenko
