Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Bill Farner
On Jan. 16, 2014, 8:36 p.m., Bill Farner wrote: src/main/python/apache/aurora/client/commands/admin.py, line 38 https://reviews.apache.org/r/16983/diff/1/?file=424929#file424929line38 Logic does not seem correct here. Can they both be 'falsey'? I'm probably ignorant to

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32077 --- build.gradle https://reviews.apache.org/r/16986/#comment60770

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Tobias Weingartner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32081 --- Ship it! Ship It! - Tobias Weingartner On Jan. 16, 2014, 9:17

Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

2014-01-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16995/ --- Review request for Aurora, Kevin Sweeney and Suman Karumuri. Bugs: AURORA-45

Re: Review Request 16995: Only make the SchedulerDriver available after registered() has been called.

2014-01-16 Thread Suman Karumuri
On Jan. 16, 2014, 11:41 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/Driver.java, lines 148-149 https://reviews.apache.org/r/16995/diff/1/?file=425119#file425119line148 There's a (very small window) check-then-act race here. Should this be synchronized or

Re: Review Request 16985: Script to create Python sdists.

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/ --- (Updated Jan. 16, 2014, 4:56 p.m.) Review request for Aurora and Brian

Re: Review Request 16615: Client command hooks doc

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/#review32113 --- I've committed this change at

Re: Review Request 16601: Adding initial image in images directory

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16601/#review32114 --- This was included in the larger commit